Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [VC-35738] Various #603

Closed
wants to merge 2 commits into from
Closed

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Oct 31, 2024

No description provided.

@wallrj wallrj force-pushed the VC-35738/remove-legacy-log-module branch 2 times, most recently from 3cdceb4 to 4b83798 Compare October 31, 2024 16:59
@wallrj wallrj force-pushed the VC-35738/remove-log-fatal branch 3 times, most recently from 704847d to 045142c Compare November 5, 2024 13:24
@wallrj wallrj force-pushed the VC-35738/remove-legacy-log-module branch from 4b83798 to cc89ee5 Compare November 5, 2024 15:20
Base automatically changed from VC-35738/remove-log-fatal to VC-35738/feature November 5, 2024 16:07
@wallrj wallrj mentioned this pull request Nov 5, 2024
12 tasks
@wallrj wallrj force-pushed the VC-35738/remove-legacy-log-module branch from cc89ee5 to 4950b1f Compare November 5, 2024 16:21
@wallrj wallrj force-pushed the VC-35738/remove-legacy-log-module branch from 4950b1f to 6b406fb Compare November 6, 2024 09:42
@wallrj wallrj changed the title WIP: [VC-35738] Use global slog logger instead of log WIP: [VC-35738] Use klog and logr logger instead of log Nov 6, 2024
Signed-off-by: Richard Wall <[email protected]>
@wallrj wallrj changed the base branch from VC-35738/feature to VC-35738/errgroup-return-error November 6, 2024 17:34
Base automatically changed from VC-35738/errgroup-return-error to VC-35738/feature November 7, 2024 10:27
@wallrj wallrj changed the title WIP: [VC-35738] Use klog and logr logger instead of log WIP: [VC-35738] Various Nov 7, 2024
Base automatically changed from VC-35738/feature to master November 14, 2024 12:26
@wallrj
Copy link
Member Author

wallrj commented Nov 20, 2024

Closing. This was just a collection of changes which I have since broken out into smaller logging PRs.

@wallrj wallrj closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant