Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subquery relationship names should not use SObject #35

Closed
1 of 2 tasks
paustint opened this issue Oct 19, 2018 · 0 comments · Fixed by #38
Closed
1 of 2 tasks

Subquery relationship names should not use SObject #35

paustint opened this issue Oct 19, 2018 · 0 comments · Fixed by #38
Assignees
@paustint
Labels
bug Something isn't working
Milestone
Release-1

Comments

@paustint
Copy link
Collaborator

  • Feature
  • Bug Request

Description

the SObject field on the results does not make sense to use for subqueries, as it is really the child relationship name.

There should be a new field on Query to indicate the name, since we really don't know the actual SObject name
@paustint paustint added the bug Something isn't working label Oct 19, 2018
@paustint paustint added this to the Release-1 milestone Oct 19, 2018
@paustint paustint self-assigned this Oct 19, 2018
paustint added a commit that referenced this issue Oct 20, 2018
@paustint
Subquery relationship names should not use SObject #35
38f4032 
Added differentiated sobject name for subqueries since it is actually the relationship name
Updated docs
Updated unit tests
Modified object prefixes to be an array and added support for multiple prefixes

resolves #35
@paustint paustint mentioned this issue Oct 20, 2018
Merged
paustint added a commit that referenced this issue Oct 20, 2018
@paustint
Merge pull request #38 from paustint/bug-35
58e15d7 
Subquery relationship names should not use SObject #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paustint paustint

Labels
bug Something isn't working
Projects
None yet
Milestone
Release-1
Development

Successfully merging a pull request may close this issue.

Subquery relationship names should not use SObject #35 jetstreamapp/soql-parser-js
1 participant
@paustint