PR #12441 - changes from review

Signed-off-by: Lachlan Roberts <[email protected]>
jetty · Nov 7, 2024 · 89cc46f · 89cc46f
1 parent d04917f
commit 89cc46f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/...er/src/main/java/org/eclipse/jetty/websocket/server/internal/UpgradeResponseDelegate.java b/...er/src/main/java/org/eclipse/jetty/websocket/server/internal/UpgradeResponseDelegate.java
@@ -13,7 +13,6 @@
 
 package org.eclipse.jetty.websocket.server.internal;
 
-import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -63,7 +62,7 @@ public Set<String> getHeaderNames()
     @Override
     public Map<String, List<String>> getHeaders()
     {
-        return Collections.unmodifiableMap(HttpFields.asMap(response.getHeaders()));
+        return HttpFields.asMap(response.getHeaders());
     }
 
     @Override

diff --git a/...ava/org/eclipse/jetty/ee10/websocket/jakarta/server/internal/JakartaWebSocketCreator.java b/...ava/org/eclipse/jetty/ee10/websocket/jakarta/server/internal/JakartaWebSocketCreator.java
@@ -166,7 +166,8 @@ public Map<String, Object> getUserProperties()
         }
         catch (Throwable x)
         {
-            LOG.warn("Unable to create websocket: {}", config.getEndpointClass().getName(), x);
+            if (LOG.isDebugEnabled())
+                LOG.debug("Unable to create websocket: {}", config.getEndpointClass().getName(), x);
             Response.writeError(request, response, callback, HttpStatus.INTERNAL_SERVER_ERROR_500, "Unable to create WebSocket");
             return null;
         }

diff --git a/...java/org/eclipse/jetty/ee9/websocket/jakarta/server/internal/JakartaWebSocketCreator.java b/...java/org/eclipse/jetty/ee9/websocket/jakarta/server/internal/JakartaWebSocketCreator.java
@@ -166,7 +166,8 @@ public Map<String, Object> getUserProperties()
         }
         catch (Throwable x)
         {
-            LOG.warn("Unable to create WebSocket: {}", config.getEndpointClass().getName(), x);
+            if (LOG.isDebugEnabled())
+                LOG.debug("Unable to create WebSocket: {}", config.getEndpointClass().getName(), x);
             Response.writeError(request, response, callback, HttpStatus.INTERNAL_SERVER_ERROR_500, "Unable to create WebSocket");
             return null;
         }