Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UTF-8 NFC/NFD tests fail on Macos #11594

Closed
lorban opened this issue Mar 29, 2024 · 3 comments · Fixed by #11619
Closed

UTF-8 NFC/NFD tests fail on Macos #11594

lorban opened this issue Mar 29, 2024 · 3 comments · Fixed by #11619
Assignees
@lorban
Labels
Bug For general bugs on Jetty side Mac OSX For issues unique to Mac OSX Test

Comments

@lorban
Copy link
Contributor

lorban commented Mar 29, 2024

Jetty version(s)
12.0.x

Java version/vendor (use: java -version)
OpenJDK Runtime Environment Temurin-17.0.8+7 (build 17.0.8+7)

OS type/version
Macos Monterey 12.7.4

Description
ResourceHandlerTest.testGetUtf8NfcFile() and ResourceHandlerTest.testGetUtf8NfdFile() both fail on Macos.

See:
@lorban lorban added Bug For general bugs on Jetty side Test labels Mar 29, 2024
@joakime joakime added the Mac OSX For issues unique to Mac OSX label Mar 29, 2024
@joakime
Copy link
Contributor

joakime commented Mar 29, 2024

Did they work on Jetty 12.0.0? what about Jetty 10.0.20?
I've noticed recently that these are failing on 12.0.8-SNAPSHOT on Windows as well.

@lorban
Copy link
Contributor Author

lorban commented Mar 29, 2024

Not sure about 12.0.0 but they do pass on 11.0.x: https://jenkins.webtide.net/job/nightlies/job/jetty-11.0.x-mac-nightly/480/

lorban added a commit that referenced this issue Apr 2, 2024
@lorban
#11594 add alias check to allow all context resources to be served, a…
a27e895 
…s for the equivalent servlet tests

Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Apr 2, 2024
Merged
@lorban lorban self-assigned this Apr 2, 2024
@lorban lorban moved this to 👀 In review in Jetty 12.0.9 - FROZEN Apr 2, 2024
@lorban
Copy link
Contributor Author

lorban commented Apr 2, 2024

The tests do not fail on 11 because they add a AllowedResourceAliasChecker, exactly like their 12.0.x counterparts.

@lorban lorban moved this from 👀 In review to 🏗 In progress in Jetty 12.0.9 - FROZEN Apr 2, 2024
lorban added a commit that referenced this issue Apr 4, 2024
@lorban
#11594 add alias check to allow all context resources to be served, a…
66c1c3b 
…s for the equivalent servlet tests

Signed-off-by: Ludovic Orban <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.9 - FROZEN Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Bug For general bugs on Jetty side Mac OSX For issues unique to Mac OSX Test
Projects
No open projects
Jetty 12.0.9 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix UTF-8 NFC/NFD tests failures on Macos jetty/jetty.project
2 participants
@joakime @lorban