Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: org.eclipse.jetty.client.ConnectionPoolTest #2540

Closed
gregw opened this issue May 16, 2018 · 0 comments
Closed

Flaky test: org.eclipse.jetty.client.ConnectionPoolTest #2540

gregw opened this issue May 16, 2018 · 0 comments
Assignees
Labels

Comments

@gregw
Copy link
Contributor

gregw commented May 16, 2018

Fails frequently when built from the command line:

[INFO] Running org.eclipse.jetty.client.ConnectionPoolTest
2018-05-16 13:03:00.158:INFO:oejs.Server:main: jetty-9.4.11-SNAPSHOT; built: 2018-05-16T02:51:18.393Z; git: d8795350a4c102ea8ee4e9661a04d8ee3f1cdf17; jvm 9.0.1+11
2018-05-16 13:03:00.163:INFO:oejs.AbstractConnector:main: Started ServerConnector@53a645a2{HTTP/1.1,[http/1.1]}{0.0.0.0:45683}
2018-05-16 13:03:00.163:INFO:oejs.Server:main: Started @154400ms
1024 requests in 663 ms, 1544.495 req/s
1024 requests in 667 ms, 1535.232 req/s
1024 requests in 670 ms, 1528.358 req/s
1024 requests in 671 ms, 1526.080 req/s
1024 requests in 682 ms, 1501.466 req/s
1024 requests in 690 ms, 1484.058 req/s
1024 requests in 691 ms, 1481.910 req/s
1024 requests in 701 ms, 1460.770 req/s
1024 requests in 567 ms, 1805.996 req/s
1024 requests in 549 ms, 1865.209 req/s
1024 requests in 584 ms, 1753.425 req/s
1024 requests in 611 ms, 1675.941 req/s
1024 requests in 589 ms, 1738.540 req/s
1024 requests in 620 ms, 1651.613 req/s
1024 requests in 632 ms, 1620.253 req/s
1024 requests in 633 ms, 1617.694 req/s
1024 requests in 537 ms, 1906.890 req/s
1024 requests in 512 ms, 2000.000 req/s
1024 requests in 559 ms, 1831.843 req/s
1024 requests in 529 ms, 1935.728 req/s
1024 requests in 547 ms, 1872.029 req/s
1024 requests in 563 ms, 1818.828 req/s
1024 requests in 543 ms, 1885.820 req/s
1024 requests in 527 ms, 1943.074 req/s
1024 requests in 496 ms, 2064.516 req/s
1024 requests in 491 ms, 2085.540 req/s
1024 requests in 488 ms, 2098.361 req/s
1024 requests in 473 ms, 2164.905 req/s
1024 requests in 471 ms, 2174.098 req/s
1024 requests in 481 ms, 2128.898 req/s
1024 requests in 451 ms, 2270.510 req/s
1024 requests in 480 ms, 2133.333 req/s
2018-05-16 13:03:02.490:INFO:oejs.AbstractConnector:main: Stopped ServerConnector@53a645a2{HTTP/1.1,[http/1.1]}{0.0.0.0:0}
2018-05-16 13:03:02.491:INFO:oejs.Server:main: jetty-9.4.11-SNAPSHOT; built: 2018-05-16T02:51:18.393Z; git: d8795350a4c102ea8ee4e9661a04d8ee3f1cdf17; jvm 9.0.1+11
2018-05-16 13:03:02.492:INFO:oejs.AbstractConnector:main: Started ServerConnector@403f6c04{HTTP/1.1,[http/1.1]}{0.0.0.0:42065}
2018-05-16 13:03:02.492:INFO:oejs.Server:main: Started @156729ms
1024 requests in 461 ms, 2221.258 req/s
1024 requests in 471 ms, 2174.098 req/s
1024 requests in 482 ms, 2124.481 req/s
1024 requests in 496 ms, 2064.516 req/s
1024 requests in 508 ms, 2015.748 req/s
1024 requests in 520 ms, 1969.231 req/s
1024 requests in 521 ms, 1965.451 req/s
1024 requests in 534 ms, 1917.603 req/s
1024 requests in 434 ms, 2359.447 req/s
1024 requests in 437 ms, 2343.249 req/s
1024 requests in 439 ms, 2332.574 req/s
1024 requests in 425 ms, 2409.412 req/s
1024 requests in 430 ms, 2381.395 req/s
1024 requests in 430 ms, 2381.395 req/s
1024 requests in 447 ms, 2290.828 req/s
1024 requests in 447 ms, 2290.828 req/s
1024 requests in 383 ms, 2673.629 req/s
1024 requests in 389 ms, 2632.391 req/s
1024 requests in 429 ms, 2386.946 req/s
1024 requests in 430 ms, 2381.395 req/s
1024 requests in 413 ms, 2479.419 req/s
1024 requests in 410 ms, 2497.561 req/s
1024 requests in 407 ms, 2515.971 req/s
1024 requests in 404 ms, 2534.653 req/s
1024 requests in 388 ms, 2639.175 req/s
1024 requests in 391 ms, 2618.926 req/s
1024 requests in 390 ms, 2625.641 req/s
1024 requests in 380 ms, 2694.737 req/s
1024 requests in 372 ms, 2752.688 req/s
1024 requests in 353 ms, 2900.850 req/s
1024 requests in 367 ms, 2790.191 req/s
1024 requests in 346 ms, 2959.538 req/s
2018-05-16 13:03:04.227:INFO:oejs.AbstractConnector:main: Stopped ServerConnector@403f6c04{HTTP/1.1,[http/1.1]}{0.0.0.0:0}
[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.077 s <<< FAILURE! - in org.eclipse.jetty.client.ConnectionPoolTest
[ERROR] test[1](org.eclipse.jetty.client.ConnectionPoolTest)  Time elapsed: 1.741 s  <<< FAILURE!
java.lang.AssertionError: [java.util.concurrent.ExecutionException: java.nio.channels.AsynchronousCloseException, java.util.concurrent.ExecutionException: java.nio.channels.AsynchronousCloseException, java.util.concurrent.ExecutionException: java.nio.channels.AsynchronousCloseException]
	at org.eclipse.jetty.client.ConnectionPoolTest.test(ConnectionPoolTest.java:145)
gregw added a commit that referenced this issue May 16, 2018
Signed-off-by: Greg Wilkins <[email protected]>
@janbartel janbartel added the Test label May 29, 2018
@joakime joakime closed this as completed Nov 6, 2018
sbordet added a commit that referenced this issue May 26, 2020
Fixed connection pool's `acquire()` methods to correctly take into account the number of queued requests.

Also fixed a collateral bug in `BufferingResponseListener` - wrong calculation of the max content length.

Restored `ConnectionPoolTest` that was disabled in #2540, cleaned it up, and let it run for hours without failures.

Signed-off-by: Simone Bordet <[email protected]>
sbordet added a commit that referenced this issue Jun 1, 2020
…4911)

* Fixes #4904 - WebsocketClient creates more connections than needed.

Fixed connection pool's `acquire()` methods to correctly take into account the number of queued requests.
Now the connection creation is conditional, triggered by
explicit send() or failures.
The connection creation is not triggered _after_ a send(),
where we aggressively send more queued requests - or
in release(), where we send queued request after a previous
one was completed.
Now the connection close/removal aggressively sends more
requests triggering the connection creation.

Also fixed a collateral bug in `BufferingResponseListener` - wrong calculation of the max content length.

Restored `ConnectionPoolTest` that was disabled in #2540, cleaned it up, and let it run for hours without failures.

Signed-off-by: Simone Bordet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants