Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of test dependencies on derby #5713

Closed
janbartel opened this issue Nov 23, 2020 · 1 comment · Fixed by #5728
Closed

Get rid of test dependencies on derby #5713

janbartel opened this issue Nov 23, 2020 · 1 comment · Fixed by #5728

Comments

@janbartel
Copy link
Contributor

There are 2 modules with test dependencies on derby:

  • jetty-plus
  • test-loginservice

jetty-plus is not actually dependent on derby for testing, and the dependency can be deleted.
We should also try to remove the dependency for the test-loginservice and replace it with mocks where necessary.
@joakime
Copy link
Contributor

joakime commented Nov 23, 2020

Duplicate of #5712

@joakime joakime marked this as a duplicate of #5712 Nov 23, 2020
janbartel added a commit that referenced this issue Nov 25, 2020
@janbartel
Issue #5713 Remove dependency on derby
6368be1 
Signed-off-by: Jan Bartel <[email protected]>
@janbartel janbartel mentioned this issue Nov 25, 2020
Merged
@janbartel janbartel linked a pull request Nov 25, 2020 that will close this issue
Issue #5713 Remove dependency on derby #5728
Merged
janbartel added a commit that referenced this issue Nov 30, 2020
@janbartel @olamy
Issue #5713 Remove dependency on derby (#5728)
5ad1305 
* Issue #5713 Remove dependency on derby

Signed-off-by: Jan Bartel <[email protected]>

* use the mariadb client version from the property

Signed-off-by: olivier lamy <[email protected]>

Co-authored-by: olivier lamy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #5713 Remove dependency on derby jetty/jetty.project
2 participants
@joakime @janbartel