ServerConnector leaks closed sockets which can lead to file descriptor exhaustion #5794

joewitt · 2020-12-10T21:59:12Z

Jetty version
9.4.35.v20201120 and older
Java version
OpenJDK Runtime Environment (build 1.8.0_272-b10) and others
OS type/version
OSX and Linux
Description
The ServerConnector class in openAcceptChannel creates a local variable which is an opened server socket channel. Then when attempting to bind to the specified port, if there is an exception, it will throw a new exception and not clean up the created channel/resource. The fix is to ensure that in the event of a bind exception the serverChannel is properly closed before throwing the exception back to the caller. Without this change the socket will be in a CLOSED state and a file descriptor held for it for the remainder of the life of the process.

…ailed bind to ensure proper resources are cleaned Signed-off-by: Joe Witt <[email protected]>

Fix #5794 Close socket on bind failure

Issue #5794 ensuring serverChannel is closed in the event of a failed bind to ensure proper resources are cleaned

Fix #5794 Close socket on bind failure

Update fix with IO.close()

* Fix #5794 Close socket on bind failure Fix #5794 Close socket on bind failure * Fix #5794 Close socket on bind failure Fix #5794 Close socket on bind failure * Fix #5794 Close socket on bind failure Update fix with IO.close()

gregw · 2020-12-14T11:17:40Z

#5802 modified to be based on #5797 and both now merged. thanks @joewitt

joewitt added a commit to joewitt/jetty.project that referenced this issue Dec 11, 2020

Issue jetty#5794 ensuring serverChannel is closed in the event of a f…

c7c8e64

…ailed bind to ensure proper resources are cleaned Signed-off-by: Joe Witt <[email protected]>

joewitt added a commit to joewitt/jetty.project that referenced this issue Dec 11, 2020

Issue jetty#5794 ensuring serverChannel is closed in the event of a f…

f7d4b94

…ailed bind to ensure proper resources are cleaned Signed-off-by: Joe Witt <[email protected]>

joewitt mentioned this issue Dec 11, 2020

Issue #5794 ensuring serverChannel is closed in the event of a failed bind to ensure proper resources are cleaned #5797

Merged

gregw self-assigned this Dec 12, 2020

gregw added a commit that referenced this issue Dec 12, 2020

Fix #5794 Close socket on bind failure

9349ed2

Fix #5794 Close socket on bind failure

gregw mentioned this issue Dec 12, 2020

Fix #5794 Close socket on bind failure #5802

Merged

gregw added a commit that referenced this issue Dec 12, 2020

Fix #5794 Close socket on bind failure

7125d8d

Fix #5794 Close socket on bind failure

sbordet added a commit that referenced this issue Dec 14, 2020

Merge pull request #5797 from joewitt/jetty-9.4.x

db68a31

Issue #5794 ensuring serverChannel is closed in the event of a failed bind to ensure proper resources are cleaned

gregw added a commit that referenced this issue Dec 14, 2020

Fix #5794 Close socket on bind failure

f2e8706

Fix #5794 Close socket on bind failure

gregw added a commit that referenced this issue Dec 14, 2020

Fix #5794 Close socket on bind failure

420093e

Update fix with IO.close()

gregw closed this as completed Dec 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ServerConnector leaks closed sockets which can lead to file descriptor exhaustion #5794

ServerConnector leaks closed sockets which can lead to file descriptor exhaustion #5794

joewitt commented Dec 10, 2020

gregw commented Dec 14, 2020

ServerConnector leaks closed sockets which can lead to file descriptor exhaustion #5794

ServerConnector leaks closed sockets which can lead to file descriptor exhaustion #5794

Comments

joewitt commented Dec 10, 2020

gregw commented Dec 14, 2020