Simplify command line use of org.eclipse.jetty.util.Password

[joakime]

Jetty version(s)
10+

Java version/vendor (use: java -version)
All

OS type/version
All

Description
The documentation gives example on using org.eclipse.jetty.util.Password like ...

 java -cp lib/jetty-util-{VERSION}.jar org.eclipse.jetty.util.security.Password

Usage - java org.eclipse.jetty.util.security.Password [<user>] <password>
If the password is ?, the user will be prompted for the password

and

$ java -cp ../lib/jetty-util-{VERSION}.jar org.eclipse.jetty.util.security.Password username password
2017-12-13 11:19:27.928:INFO::main: Logging initialized @95ms to org.eclipse.jetty.util.log.StdErrLog
password
OBF:1v2j1uum1xtv1zej1zer1xtn1uvk1v1v
MD5:5f4dcc3b5aa765d61d8327deb882cf99
CRYPT:usjRS48E8ZADM

But the org.eclipse.jetty.util.security.Password class has logging, so this makes the command line a bit more complex ...

Example:

[jetty-home-10.0.7]$ java -cp lib/jetty-util-10.0.7.jar org.eclipse.jetty.util.security.Password HelloWorld
Exception in thread "main" java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory
	at org.eclipse.jetty.util.security.Credential.<clinit>(Credential.java:43)
Caused by: java.lang.ClassNotFoundException: org.slf4j.LoggerFactory
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
	... 1 more

I see a few options here.

1. The simplest approach would be to just remove the logging from Password and Credential, but that hurts normal usage of those classes.

2. Document how to add slf4j-api and jetty-slf4j-impl to the command line.

3. Introduce a new PasswordCli class that doesn't use Credential or logging at all.

4. Introduce a start.jar option that just runs org.eclipse.jetty.util.security.Password with the appropriate classloader setup. (--password ?)

[joakime]

For the record, the minimal command line is now ...

$ java -cp lib/jetty-util-10.0.7.jar:lib/logging/slf4j-api-2.0.0-alpha5.jar:lib/logging/jetty-slf4j-impl-10.0.7.jar org.eclipse.jetty.util.security.Password HelloWorld
HelloWorld
OBF:1n4z1ugo1x151wfw1sbb1s9z1wg21x1h1uh21n6j
MD5:68e109f0f40ca72a15e05cc22786f8e6

[janbartel]

Possibly the Password and Credential classes could be changed to throw ISE insead of doing logging. Some of the logging they're doing is pretty questionable anyway (see https://github.com/eclipse/jetty.project/blob/0ad49fd1fd9565eeec3878d9e5c0e986ec272dbd/jetty-util/src/main/java/org/eclipse/jetty/util/security/Credential.java#L158 - prints out a warning it can't check CRYPT and then goes on to check it anyway??).

Having a new start.jar option would be nice, but then again the downside is that it means you have to have a full distro in order to use it.

Maybe another option - could we make another jar artifact during the build of jetty-util that just contains everything necessary to run Password on the command line?

[olamy]

Maybe another option - could we make another jar artifact during the build of jetty-util that just contains everything necessary to run Password on the command line?

maybe a very simple jetty-util shaded jar with necessary logging impl (i.e simple slf4j)?