Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Charset instead of encoding string where possible #7131

Closed
mperktold opened this issue Nov 17, 2021 · 2 comments · Fixed by #7137
Closed

Use Charset instead of encoding string where possible #7131

mperktold opened this issue Nov 17, 2021 · 2 comments · Fixed by #7137
Assignees

Comments

@mperktold
Copy link

Target Jetty version(s)
Jetty 10.0.x

Enhancement Description
We've noticed a few places where a string charset is passed to a JDK method even if it would be possible to directly use a Charset instead:

Maybe there are some more, but those are the ones we found.

This is more of an observation rather than a feature request.

Also, the corresponding overloads accepting a Charset are only available since Java 10, which is fine for Jetty 10 but not for Jetty 9, so please decide for yourself whether this is worthwhile.

joakime added a commit that referenced this issue Nov 19, 2021
@joakime joakime linked a pull request Nov 19, 2021 that will close this issue
@joakime
Copy link
Contributor

joakime commented Nov 19, 2021

Opened as PR #7137

joakime added a commit that referenced this issue Nov 19, 2021
@joakime
Copy link
Contributor

joakime commented Nov 19, 2021

Merged into jetty-10.0.x and jetty-11.0.x

@joakime joakime self-assigned this Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants