Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jetty-10 amenable to testing with SNAPSHOT jsp jars #7632

Closed
janbartel opened this issue Feb 21, 2022 · 0 comments · Fixed by #7633
Closed

Make jetty-10 amenable to testing with SNAPSHOT jsp jars #7632

janbartel opened this issue Feb 21, 2022 · 0 comments · Fixed by #7633
Assignees
Labels

Comments

@janbartel
Copy link
Contributor

jetty-10

Use the same pom.xml code as in jetty-11 to convert a version that may include SNAPSHOT into an osgi-acceptable form:

      <plugin>
        <groupId>org.codehaus.mojo</groupId>
        <artifactId>build-helper-maven-plugin</artifactId>
        <executions>
          <execution>
              <id>set-jsp-api-version</id>
              <phase>validate</phase>
              <goals>
                  <goal>parse-version</goal>
              </goals>
              <configuration>
                  <versionString>${jsp.impl.version}</versionString>
                  <propertyPrefix>jspImpl</propertyPrefix>
              </configuration>
          </execution>
        </executions>
      </plugin>
@janbartel janbartel added the Bug For general bugs on Jetty side label Feb 21, 2022
@janbartel janbartel self-assigned this Feb 21, 2022
janbartel added a commit that referenced this issue Feb 21, 2022
janbartel added a commit that referenced this issue Feb 22, 2022
@joakime joakime added Test and removed Bug For general bugs on Jetty side labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants