Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating various old/moved URL references found across project (jetty-12.0.x) #10096

Closed
wants to merge 3 commits into from
Closed

Updating various old/moved URL references found across project (jetty-12.0.x) #10096

wants to merge 3 commits into from

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jul 11, 2023 •
edited
Loading

Now that the migration of https://eclipse.org/jetty/ to https://eclipse.dev/jetty/ has occurred, it is time to review the URI use in our project

  • Updated URLs in poms
  • Added more URIs in XML Catalogs
  • Updated URLs in module files
  • Updated URLs in documentation
  • Updated URLs in HTML
  • Correcting bad double-scheme URLs (eg: http://https://www.eclipse...)

@joakime
Updating various URIs.
e60e013 
+ Updated URIs in poms
+ Added more URIs in XML Catalogs
+ Updated URIs in module files
+ Updated URIs in documentation
@joakime joakime added this to the 12.0.x milestone Jul 11, 2023
@joakime joakime requested review from sbordet and lorban July 11, 2023 15:53
@joakime joakime self-assigned this Jul 11, 2023
@joakime joakime changed the title Updating various URIs. Updating various old/moved URI references found across project Jul 11, 2023
@joakime joakime changed the title Updating various old/moved URI references found across project Updating various old/moved URL references found across project Jul 11, 2023
@joakime joakime changed the title Updating various old/moved URL references found across project Updating various old/moved URL references found across project (jetty-12.0.x) Jul 11, 2023
lorban
lorban requested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changeset looks alright, but I'm wondering if a good deal of them shouldn't come from a merge of #10098 ?

...ee10/jetty-ee10-demos/jetty-ee10-demo-jaas-webapp/src/main/config/modules/ee10-demo-jaas.mod
@@ -1,4 +1,4 @@
# DO NOT EDIT - See: https://www.eclipse.org/jetty/documentation/current/startup-modules.html
# DO NOT EDIT THIS FILE - Use start modules correctly - See: https://eclipse.dev/jetty/documentation/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the same sentence that was suggested in #10098 (review)

@joakime joakime marked this pull request as draft July 14, 2023 12:12
@joakime
Copy link
Contributor Author

joakime commented Jul 14, 2023

Closing.
I'll recreate this PR as a merge commit from jetty-11 instead.

@joakime joakime closed this Jul 14, 2023
@joakime joakime deleted the fix/12.0.x/new-eclipse.dev-uri branch July 14, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorban lorban lorban requested changes

@sbordet sbordet Awaiting requested review from sbordet

Assignees

@joakime joakime

Labels
Build
Projects
None yet
Milestone
12.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@joakime @lorban