Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and javadoc HttpContent API #12069

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Jul 22, 2024

Followup work to #12020.

  • Remove release() from the API
  • Remove redundant methods from the API
  • Javadoc HttpContent

Fixes #9080

@lorban lorban requested review from gregw and sbordet July 22, 2024 11:28
@lorban lorban self-assigned this Jul 22, 2024
@lorban lorban changed the base branch from jetty-12.0.x to jetty-12.1.x July 22, 2024 11:28
@lorban lorban changed the base branch from jetty-12.1.x to experiment/jetty-12.1.x/HttpContent-writeTo July 22, 2024 11:29
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the direction this is going

@lorban lorban requested a review from gregw July 23, 2024 11:39
@lorban lorban changed the title Experiment/jetty 12.1/http content no release Cleanup and javadoc HttpContent API Jul 24, 2024
Base automatically changed from experiment/jetty-12.1.x/HttpContent-writeTo to jetty-12.1.x July 24, 2024 12:07
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban force-pushed the experiment/jetty-12.1/HttpContent-no-release branch from 84ab360 to b62edbf Compare July 24, 2024 13:18
@lorban
Copy link
Contributor Author

lorban commented Jul 24, 2024

I had to force-push because github made an unmergeable mess of this PR after I merged #12020.

Sorry about that!

@lorban lorban marked this pull request as ready for review July 24, 2024 13:21
@lorban lorban linked an issue Jul 24, 2024 that may be closed by this pull request
@gregw gregw merged commit a9a0f16 into jetty-12.1.x Jul 25, 2024
9 checks passed
@lorban lorban deleted the experiment/jetty-12.1/HttpContent-no-release branch July 25, 2024 06:57
@olamy olamy mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Jetty-12 HttpContent javadoc
2 participants