Fixes #11822 - HTTP/2 responses exceeding SETTINGS_MAX_HEADER_LIST_SIZE do not result in RST_STREAM or GOAWAY. #12165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ZE do not result in RST_STREAM or GOAWAY. Now HpackException.SessionException is treated specially in HTTP2Flusher. It is caught, it fails all the entries, and then tries to send a GOAWAY, which will be the only frame allowed into the HTTP2FLusher at that point. Signed-off-by: Simone Bordet <[email protected]>
lorban
previously approved these changes
Aug 15, 2024
Signed-off-by: Simone Bordet <[email protected]>
gregw
requested changes
Aug 18, 2024
...ty-http2/jetty-http2-common/src/main/java/org/eclipse/jetty/http2/internal/HTTP2Flusher.java
Outdated
Show resolved
Hide resolved
...ty-http2/jetty-http2-common/src/main/java/org/eclipse/jetty/http2/internal/HTTP2Flusher.java
Show resolved
Hide resolved
...ty-http2/jetty-http2-common/src/main/java/org/eclipse/jetty/http2/internal/HTTP2Flusher.java
Outdated
Show resolved
Hide resolved
...ty-http2/jetty-http2-common/src/main/java/org/eclipse/jetty/http2/internal/HTTP2Flusher.java
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <[email protected]>
gregw
requested changes
Aug 21, 2024
| if (entry != null && entry.frame().getType() == FrameType.GO_AWAY) | ||
| { | ||
| // Allow a SessionException to be processed once to send a GOAWAY. | ||
| terminated = new ClosedChannelException().initCause(terminated); |
There was a problem hiding this comment.
Does not hurt, we want to send the GOAWAY only once.
gregw
approved these changes
Aug 26, 2024
sbordet
deleted the
fix/jetty-12.0.x/11822/handle-exceeded-max-header-list-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now HpackException.SessionException is treated specially in HTTP2Flusher.
It is caught, it fails all the entries, and then tries to send a GOAWAY, which will be the only frame allowed into the HTTP2FLusher at that point.