Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11581 - Flaky WebSocketOverHTTP2Test.testWebSocketOverDynamicHTTP2() #12236

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Sep 4, 2024

Marked the test as flaky, actual resolution needs resolving #12235.

…TTP2()

Marked the test as flaky, actual resolution needs resolving #12235.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet requested review from gregw and lorban September 4, 2024 10:05
@sbordet
Copy link
Contributor Author

sbordet commented Sep 4, 2024

@gregw @lorban turned out that the test can fail in multiple ways, so rather than workaround all asserts, I just marked it as flaky.

@sbordet sbordet merged commit c2519bb into jetty-12.0.x Sep 5, 2024
10 checks passed
@sbordet sbordet deleted the fix/jetty-12.0.x/11581/flaky-ws-over-h2 branch September 5, 2024 10:16
lachlan-roberts added a commit that referenced this pull request Sep 5, 2024
Signed-off-by: Lachlan Roberts <[email protected]>
@olamy olamy mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants