Document hidden and protected classes #12511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #12106 by documenting hidden and protected classes.
janbartel
requested changes
Nov 11, 2024
documentation/jetty/modules/programming-guide/pages/server/http.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/server/http.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/server/http.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/server/http.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/server/http.adoc
Outdated
Show resolved
Hide resolved
jetty-ee11/jetty-ee11-webapp/src/main/java/org/eclipse/jetty/ee11/webapp/WebAppContext.java
Outdated
Show resolved
Hide resolved
jetty-ee11/jetty-ee11-webapp/src/main/java/org/eclipse/jetty/ee11/webapp/WebAppContext.java
Outdated
Show resolved
Hide resolved
jetty-ee11/jetty-ee11-webapp/src/main/java/org/eclipse/jetty/ee11/webapp/WebAppContext.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Bartel <[email protected]>
janbartel
approved these changes
Nov 12, 2024
| @@ -672,22 +677,28 @@ public void addHiddenClassMatcher(ClassMatcher hiddenClasses) | |||
| * any existing matcher. | |||
| * | |||
| * @param protectedClasses The class matcher of patterns to add to the system ClassMatcher | |||
There was a problem hiding this comment.
Suggested change
| * @param protectedClasses The class matcher of patterns to add to the system ClassMatcher | |
| * @param protectedClasses The class matcher of patterns to add to the protected (system) ClassMatcher |
| @@ -661,6 +664,8 @@ public void setProtectedClassMatcher(ClassMatcher protectedClasses) | |||
| * any existing matcher. | |||
| * | |||
| * @param hiddenClasses The class matcher of patterns to add to the server ClassMatcher | |||
There was a problem hiding this comment.
Suggested change
| * @param hiddenClasses The class matcher of patterns to add to the server ClassMatcher | |
| * @param hiddenClasses The class matcher of patterns to add to the hidden (server) ClassMatcher |
| */ | ||
| public void addProtectedClassMatcher(ClassMatcher protectedClasses) | ||
| { | ||
| _protectedClasses.add(protectedClasses.getPatterns()); | ||
| } | ||
|
|
||
| /** | ||
| * @return The ClassMatcher used to match System (protected) classes | ||
| * @return The ClassMatcher used to match System (protected) classes to implement the |
There was a problem hiding this comment.
Suggested change
| * @return The ClassMatcher used to match System (protected) classes to implement the | |
| * @return The ClassMatcher used to match protected (system) classes to implement the |
| */ | ||
| public ClassMatcher getProtectedClassMatcher() | ||
| { | ||
| return _protectedClasses; | ||
| } | ||
|
|
||
| /** | ||
| * @return The ClassMatcher used to match Server (hidden) classes | ||
| * @return The ClassMatcher used to match Server (hidden) classes to implement the |
There was a problem hiding this comment.
Suggested change
| * @return The ClassMatcher used to match Server (hidden) classes to implement the | |
| * @return The ClassMatcher used to match hidden (server) classes to implement the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12106 by documenting hidden and protected classes.