Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #4227 - do not use encodeRedirectURL for openid redirects #4233

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Issue #4227 - do not use encodeRedirectURL for openid redirects #4233

merged 2 commits into from
Oct 22, 2019

Conversation

lachlan-roberts
Copy link
Contributor

@lachlan-roberts lachlan-roberts commented Oct 22, 2019 •
edited
Loading

Signed-off-by: Lachlan Roberts [email protected]

#4227

@lachlan-roberts lachlan-roberts requested a review from gregw October 22, 2019 06:43
gregw
gregw requested changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to use Request.isRequestedSessionIdFromUrl somewhere to check if rewriting is being used. If it is, then auth should fail immediately... perhaps with a warning.

@lachlan-roberts
changes from review
115099f 
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
gregw approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better, but before merging can you create two additional issues:

  • we need to communicate the reason to the error page, probably via a query param
  • is the redirect code calculation really necessary? If so, then it should be in a utility method

@lachlan-roberts lachlan-roberts merged commit a9e543c into jetty-9.4.x Oct 22, 2019
@lachlan-roberts lachlan-roberts deleted the jetty-9.4.x-4227-OpenID-jsessionid branch October 22, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlan-roberts @gregw