Issue #6566 - add executor to WebSocketComponents & use for Dispatched Messages #6585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Messages Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
requested changes
Aug 4, 2021
...ebsocket-core-common/src/main/java/org/eclipse/jetty/websocket/core/WebSocketComponents.java
Outdated
Show resolved
Hide resolved
...-server/src/main/java/org/eclipse/jetty/websocket/core/server/WebSocketServerComponents.java
Show resolved
Hide resolved
gregw
previously approved these changes
Aug 4, 2021
Signed-off-by: Lachlan Roberts <[email protected]>
…erTest Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
approved these changes
Aug 5, 2021
Comment on lines
+61
to
+70
| if (executor == null) | ||
| { | ||
| QueuedThreadPool threadPool = new QueuedThreadPool(); | ||
| threadPool.setName("WebSocket@" + hashCode()); | ||
| _executor = threadPool; | ||
| } | ||
| else | ||
| { | ||
| _executor = executor; | ||
| } |
There was a problem hiding this comment.
If you are breaking out like this, then you may as well do:
Suggested change
| if (executor == null) | |
| { | |
| QueuedThreadPool threadPool = new QueuedThreadPool(); | |
| threadPool.setName("WebSocket@" + hashCode()); | |
| _executor = threadPool; | |
| } | |
| else | |
| { | |
| _executor = executor; | |
| } | |
| if (executor == null) | |
| { | |
| QueuedThreadPool threadPool = new QueuedThreadPool(); | |
| threadPool.setName("WebSocket@" + hashCode()); | |
| _executor = threadPool; | |
| addBean(_executor, true); | |
| } | |
| else | |
| { | |
| _executor = executor; | |
| addBean(_executor, false); | |
| } |
There was a problem hiding this comment.
Hmmm but then all the other beans are managed differently..... I still don't like how the management decision is made external to this class... but I'll live with it in this PR. But do think about fixing it sometime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6566
Use an executor to dispatch new threads for
InputStreamorReadertype messages.This doesn't fix #6566 as that issue was also reproduced using the
onMessage(ByteBuffer)style methods. But this should still offer some improvement for dispatched messages.