Issue #6566 - use the demand API for the websocket MessageSinks #6635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with their callbacks Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
requested changes
Aug 18, 2021
jetty-io/src/main/java/org/eclipse/jetty/io/BufferCallbackAccumulator.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/BufferCallbackAccumulator.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/BufferCallbackAccumulator.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/BufferCallbackAccumulator.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/eclipse/jetty/websocket/core/internal/messages/ByteArrayMessageSink.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/eclipse/jetty/websocket/core/internal/messages/ByteArrayMessageSink.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/eclipse/jetty/websocket/core/internal/messages/ByteArrayMessageSink.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/eclipse/jetty/websocket/core/internal/messages/ByteBufferMessageSink.java
Outdated
Show resolved
Hide resolved
…amMessageSinkTest failures Signed-off-by: Lachlan Roberts <[email protected]>
|
@lachlan-roberts can you fix the test failures? |
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
requested changes
Aug 23, 2021
...n/src/main/java/org/eclipse/jetty/websocket/core/internal/messages/ByteArrayMessageSink.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
force-pushed
the
jetty-10.0.x-6566-WebSocketMessageSinks
branch
from
102d1b2 to
fd6c72c
Compare
gregw
previously approved these changes
Aug 24, 2021
sbordet
requested changes
Aug 25, 2021
jetty-io/src/main/java/org/eclipse/jetty/io/BufferCallbackAccumulator.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/BufferCallbackAccumulator.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/BufferCallbackAccumulator.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/BufferCallbackAccumulator.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/BufferCallbackAccumulator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/eclipse/jetty/websocket/core/internal/messages/DispatchedMessageSink.java
Outdated
Show resolved
Hide resolved
...etty-common/src/main/java/org/eclipse/jetty/websocket/common/JettyWebSocketFrameHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
previously requested changes
Aug 26, 2021
jetty-io/src/main/java/org/eclipse/jetty/io/ByteBufferCallbackAccumulator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/eclipse/jetty/websocket/core/internal/messages/DispatchedMessageSink.java
Show resolved
Hide resolved
...etty-common/src/main/java/org/eclipse/jetty/websocket/common/JettyWebSocketFrameHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
…6566-WebSocketMessageSinks
sbordet
reviewed
Aug 28, 2021
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
requested changes
Aug 30, 2021
jetty-io/src/main/java/org/eclipse/jetty/io/ByteBufferCallbackAccumulator.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
approved these changes
Aug 30, 2021
lachlan-roberts
dismissed
sbordet’s stale review
"LGTM, but there are test failures." - sbordet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6566
By using the demand API in the websocket
MessageSinks we can demand all the frames of a websocket message without succeeding the callback and releasing control of the frame payload buffers. This allows theMessageSinks to not need to copy the payload of each buffer and just store the buffer/callback pair. Now only one copy must be done which is to combine the frame payloads directly before it is delivered to the application.