Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump maven.version from 3.8.2 to 3.8.3 #6954

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 4, 2021

Bumps maven.version from 3.8.2 to 3.8.3.
Updates maven-artifact from 3.8.2 to 3.8.3

Commits
  • ff8e977 [maven-release-plugin] prepare release maven-3.8.3
  • 0a6bbb8 [MNG-7235] Speed improvements when calculating the sorted project graph
  • 8882a9c [MNG-7164] Add constructor MojoExecutionException(Throwable)
  • ab54d17 [MNG-7253] Display relocation message defined in model
  • 8c66edc [MNG-7254] Expand Windows native libraries for Jansi due to JDK-8195129 (work...
  • d1aa1e1 [MNG-7252] Fix warnings issued by dependency:analyze
  • 93f9e85 [MNG-7045] Drop CDI API from Maven
  • 98a9d08 [MNG-7236] The DefaultPluginVersionResolver should cache results for the session
  • 1ea42b0 [MNG-7219] [Regression] plexus-cipher missing from transitive dependencies
  • 4e5b3d5 [MNG-7251] Fix threadLocalArtifactsHolder leaking into cloned project
  • Additional commits viewable in compare view

Updates maven-core from 3.8.2 to 3.8.3

Commits
  • ff8e977 [maven-release-plugin] prepare release maven-3.8.3
  • 0a6bbb8 [MNG-7235] Speed improvements when calculating the sorted project graph
  • 8882a9c [MNG-7164] Add constructor MojoExecutionException(Throwable)
  • ab54d17 [MNG-7253] Display relocation message defined in model
  • 8c66edc [MNG-7254] Expand Windows native libraries for Jansi due to JDK-8195129 (work...
  • d1aa1e1 [MNG-7252] Fix warnings issued by dependency:analyze
  • 93f9e85 [MNG-7045] Drop CDI API from Maven
  • 98a9d08 [MNG-7236] The DefaultPluginVersionResolver should cache results for the session
  • 1ea42b0 [MNG-7219] [Regression] plexus-cipher missing from transitive dependencies
  • 4e5b3d5 [MNG-7251] Fix threadLocalArtifactsHolder leaking into cloned project
  • Additional commits viewable in compare view

Updates maven-plugin-api from 3.8.2 to 3.8.3

Commits
  • ff8e977 [maven-release-plugin] prepare release maven-3.8.3
  • 0a6bbb8 [MNG-7235] Speed improvements when calculating the sorted project graph
  • 8882a9c [MNG-7164] Add constructor MojoExecutionException(Throwable)
  • ab54d17 [MNG-7253] Display relocation message defined in model
  • 8c66edc [MNG-7254] Expand Windows native libraries for Jansi due to JDK-8195129 (work...
  • d1aa1e1 [MNG-7252] Fix warnings issued by dependency:analyze
  • 93f9e85 [MNG-7045] Drop CDI API from Maven
  • 98a9d08 [MNG-7236] The DefaultPluginVersionResolver should cache results for the session
  • 1ea42b0 [MNG-7219] [Regression] plexus-cipher missing from transitive dependencies
  • 4e5b3d5 [MNG-7251] Fix threadLocalArtifactsHolder leaking into cloned project
  • Additional commits viewable in compare view

Updates maven-resolver-provider from 3.8.2 to 3.8.3

Commits
  • ff8e977 [maven-release-plugin] prepare release maven-3.8.3
  • 0a6bbb8 [MNG-7235] Speed improvements when calculating the sorted project graph
  • 8882a9c [MNG-7164] Add constructor MojoExecutionException(Throwable)
  • ab54d17 [MNG-7253] Display relocation message defined in model
  • 8c66edc [MNG-7254] Expand Windows native libraries for Jansi due to JDK-8195129 (work...
  • d1aa1e1 [MNG-7252] Fix warnings issued by dependency:analyze
  • 93f9e85 [MNG-7045] Drop CDI API from Maven
  • 98a9d08 [MNG-7236] The DefaultPluginVersionResolver should cache results for the session
  • 1ea42b0 [MNG-7219] [Regression] plexus-cipher missing from transitive dependencies
  • 4e5b3d5 [MNG-7251] Fix threadLocalArtifactsHolder leaking into cloned project
  • Additional commits viewable in compare view

Updates maven-settings from 3.8.2 to 3.8.3

Commits
  • ff8e977 [maven-release-plugin] prepare release maven-3.8.3
  • 0a6bbb8 [MNG-7235] Speed improvements when calculating the sorted project graph
  • 8882a9c [MNG-7164] Add constructor MojoExecutionException(Throwable)
  • ab54d17 [MNG-7253] Display relocation message defined in model
  • 8c66edc [MNG-7254] Expand Windows native libraries for Jansi due to JDK-8195129 (work...
  • d1aa1e1 [MNG-7252] Fix warnings issued by dependency:analyze
  • 93f9e85 [MNG-7045] Drop CDI API from Maven
  • 98a9d08 [MNG-7236] The DefaultPluginVersionResolver should cache results for the session
  • 1ea42b0 [MNG-7219] [Regression] plexus-cipher missing from transitive dependencies
  • 4e5b3d5 [MNG-7251] Fix threadLocalArtifactsHolder leaking into cloned project
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @olamy.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 4, 2021
@dependabot dependabot bot added this to the 10.0.x milestone Oct 4, 2021
@olamy
Copy link
Member

olamy commented Oct 13, 2021

@dependabot rebase

olamy
olamy previously approved these changes Oct 13, 2021
@olamy
Copy link
Member

olamy commented Oct 13, 2021

@dependabot merge

Bumps `maven.version` from 3.8.2 to 3.8.3.

Updates `maven-artifact` from 3.8.2 to 3.8.3
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-3.8.2...maven-3.8.3)

Updates `maven-core` from 3.8.2 to 3.8.3
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-3.8.2...maven-3.8.3)

Updates `maven-plugin-api` from 3.8.2 to 3.8.3
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-3.8.2...maven-3.8.3)

Updates `maven-resolver-provider` from 3.8.2 to 3.8.3
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-3.8.2...maven-3.8.3)

Updates `maven-settings` from 3.8.2 to 3.8.3
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-3.8.2...maven-3.8.3)

---
updated-dependencies:
- dependency-name: org.apache.maven:maven-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.maven:maven-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.maven:maven-plugin-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.maven:maven-resolver-provider
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.maven:maven-settings
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/jetty-10.0.x/maven.version-3.8.3 branch from e3a0dc2 to f187ae2 Compare October 13, 2021 23:17
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 14, 2021

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

olamy
olamy previously approved these changes Oct 14, 2021
@janbartel
Copy link
Contributor

@olamy the 3.8.3 version of the maven-plugin-api depends on javax.annotation ... which is banned by the enforcer plugin in jetty-11.

Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maven-plugin-api 3.8.3 depends on javax.annotation that is banned by the enforcer plugin in jetty-11. Either needs an exemption in the enforcer or maybe an exclusion in the jetty-maven-plugin pom.xml.

@olamy
Copy link
Member

olamy commented Oct 15, 2021

yup and it's wrong in maven-plugin-api as it should be provided (I think there is some work in maven to change this).
But we need to add some exclusion for now

Signed-off-by: Olivier Lamy <[email protected]>
@olamy olamy requested a review from janbartel October 19, 2021 06:26
@olamy
Copy link
Member

olamy commented Oct 19, 2021

@dependabot merge

@olamy
Copy link
Member

olamy commented Oct 26, 2021

@janbartel I need you to validate this :) thanks

@olamy
Copy link
Member

olamy commented Nov 2, 2021

@janbartel I need your review here thanks

@olamy olamy merged commit d571436 into jetty-10.0.x Nov 9, 2021
@olamy olamy deleted the dependabot/maven/jetty-10.0.x/maven.version-3.8.3 branch November 9, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants