Issue #7277 - Allow Request.getLocalName() and .getLocalPort() to be overridden

[joakime]

Uses a Connection.Listener to set the override on connections that are opened using an HttpChannel.

[joakime]

@sbordet changes applied

[gregw]

This method should always return a local authority, either one set explicitly or one that is determined dynamically in doStart (or open).
Then the layers about can just ask for the authority and not have to check if null and then look at the address etc.

[gregw]

Also make this a method on NetworkConnector

[joakime]

This is not a NetworkConnector specific concept.
We have UnixDomainConnector and LocalConnector that can benefit from setLocalAuthority() and are not network connectors.

[joakime]

We cannot "always return a local authority".
I tried it.
Going this route breaks expectations in ForwardRequestCustomizer and DetectorConnection and ProxyEndPoint behaviors, so I reverted it.

[gregw]

We should never fall through to here. If there Connector is a NetworkConnector it should always provide a local authority, otherwise return null.

[joakime]

See comment above about this feature not being NetworkConnector specific.

[gregw]

Why not keep the getLocalAuthority() here and only convert to host/port in Request

[gregw]

We should not have to do this fall back yet again here. Either is a local authority (so we have a port) or there is not (and we don't)

[joakime]

Tried this.
Going this route breaks expectations in ForwardRequestCustomizer and DetectorConnection and ProxyEndPoint behaviors, so I reverted it.

[gregw]

I can make all but the EmptyHost test pass on an unmodified jetty-9 with the following ammendment to the unit test:

    private CloseableServer startServer(HostPort localAuthority) throws Exception
    {
        Server server = new Server();

        ServerConnector connector;
        if (localAuthority == null)
        {
            connector = new ServerConnector(server);
        }
        else
        {
            InetSocketAddress authorityInetSocketAddress = InetSocketAddress.createUnresolved(localAuthority.getHost(), localAuthority.getPort());
            connector = new ServerConnector(server)
            {
                @Override
                protected ChannelEndPoint newEndPoint(SocketChannel channel, ManagedSelector selectSet, SelectionKey key) throws IOException
                {
                    SocketChannelEndPoint endpoint = new SocketChannelEndPoint(channel, selectSet, key, getScheduler())
                    {
                        @Override
                        public InetSocketAddress getLocalAddress()
                        {
                            return authorityInetSocketAddress;
                        }
                    };
                    endpoint.setIdleTimeout(getIdleTimeout());
                    return endpoint;
                }
            };
        }
        connector.setPort(0);

So I'm really reluctant to make big changes in jetty-9 when a simple extention of ServerConnector server connector can achieve pretty much the same result.

[joakime]

This PR replaced with PR #7316