Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 10.0.x: update quiche to version 0.16.0 #8699

Merged
merged 5 commits into from
Oct 18, 2022

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Oct 10, 2022

The jetty-quiche-native artifact version 0.16.0 has now been deployed to central.

See #8695 (solved when this PR gets merged into 10, 11 and 12).

@lorban lorban added the Bug For general bugs on Jetty side label Oct 10, 2022
@lorban lorban requested a review from sbordet October 10, 2022 07:30
@lorban lorban self-assigned this Oct 10, 2022
@lorban lorban force-pushed the jetty-10.0.x-8695-update-quiche-to-0-15-0 branch from c9b18cd to 14e557b Compare October 10, 2022 17:11
@lorban lorban requested a review from joakime October 10, 2022 17:14
@joakime
Copy link
Contributor

joakime commented Oct 10, 2022

This branch is having issues.

java.lang.StackOverflowError
	at [email protected]/org.eclipse.jetty.quic.quiche.QuicheConnection.connect(QuicheConnection.java:59)
	at org.eclipse.jetty.quic.quiche.jna.JnaQuicheBinding.connect(JnaQuicheBinding.java:62)
	at [email protected]/org.eclipse.jetty.quic.quiche.QuicheConnection.connect(QuicheConnection.java:59)
	at org.eclipse.jetty.quic.quiche.jna.JnaQuicheBinding.connect(JnaQuicheBinding.java:62)
	at [email protected]/org.eclipse.jetty.quic.quiche.QuicheConnection.connect(QuicheConnection.java:59)
	at org.eclipse.jetty.quic.quiche.jna.JnaQuicheBinding.connect(JnaQuicheBinding.java:62)
	at [email protected]/org.eclipse.jetty.quic.quiche.QuicheConnection.connect(QuicheConnection.java:59)
	at org.eclipse.jetty.quic.quiche.jna.JnaQuicheBinding.connect(JnaQuicheBinding.java:62)
	at [email protected]/org.eclipse.jetty.quic.quiche.QuicheConnection.connect(QuicheConnection.java:59)
	at org.eclipse.jetty.quic.quiche.jna.JnaQuicheBinding.connect(JnaQuicheBinding.java:62)
... etc ...

@lorban lorban force-pushed the jetty-10.0.x-8695-update-quiche-to-0-15-0 branch from 14e557b to f416a43 Compare October 11, 2022 08:54
joakime
joakime previously approved these changes Oct 11, 2022
…g on JDK 17 and not any older nor a more recent version.

Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban requested review from joakime and sbordet October 17, 2022 10:28
@lorban
Copy link
Contributor Author

lorban commented Oct 17, 2022

FYI, quiche 0.16.0 is now out, has been built with the native binaries published to central, and has no breaking API change so we could upgrade immediately to 0.16.0 by modifying this PR.

@joakime
Copy link
Contributor

joakime commented Oct 17, 2022

FYI, quiche 0.16.0 is now out, has been built with the native binaries published to central, and has no breaking API change so we could upgrade immediately to 0.16.0 by modifying this PR.

Yeah, lets skip 0.15.0 and go straight to 0.16.0.
No need to make a new PR (if you don't want to).
Just update this one (and change the title)

Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban changed the title Jetty 10.0.x: update quiche to version 0.15.0 Jetty 10.0.x: update quiche to version 0.16.0 Oct 17, 2022
@lorban lorban merged commit 5a9f3fb into jetty-10.0.x Oct 18, 2022
@lorban lorban deleted the jetty-10.0.x-8695-update-quiche-to-0-15-0 branch October 18, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants