-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RBLXDSS-1: Possible Support for ApiKey Authentication #77
Comments
That's another reason why apiKey authentication is a good idea, because of Forms Cookie invalidation when you change region. |
@nkpetko Could the reason I'm seeing this error using the OrderedDataStore functionality be that something changed in Roblox' APIs recently?
const dataStore = DataStoreService.GetOrderedDataStore("Redacted");
const data = await dataStore.GetSortedAsync(true, 10);
console.log(data); |
@OscarWoHA strange, I'll look into it now. |
@OscarWoHA I see what they did, they changed it to only support GET, I will try to implement a fix. |
Amazing! Thank you for the great work. |
9a5d6e0 should be the fix. Please install this via: $ npm install @mfd/[email protected] ––save |
@nkpetko Facing a new issue. Seems like the response now returns with Value and Target as lowercase therefore triggering an "MALFORMED_RESPONSE" error, example response:
|
Maybe 603e974 fixes this? Install it with: $ npm install @mfd/[email protected] ––save (clear npm cache if you can't) |
@OscarWoHA did this end up fixing your issue? |
@nkpetko Yep! Thanks a lot. |
With the light of OpenCloud, comes more and more services for tasks that could've been done before, but at the root level.
Right now you can do authentication with a ASP.NET Forms Cookie which is dangerous as it gives root level access to your Roblox user with no restrictions.
What this issue aims to enact is to support authentication via ApiKeys within the new OpenCloud DataStores Service (gamepersistence-service-bedev2).
It should be implemented by determining if the given string on AuthenticationHelper is actually a forms cookie or an apiKey format. If it's an apiKey then we can't really check universe ownership (yet) so you'll have to ensure you have permissions to the universe you are trying to access as the methods will just throw. If we are using OpenCloud authentication, GlobalDataStore and DataStore2 will swap data providers to the OpenCloudProvider while still attempting to ensure data integrity and contract behaviour.
This change will also come fourth to the newest feature set to be added which is to drastically improve the code readability and self documentation.
More to come!
The text was updated successfully, but these errors were encountered: