Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leak on res aborted on non-range requests #246

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

ronag
Copy link
Contributor

@ronag ronag commented Apr 11, 2019

Currently a non-range request which is aborted will leak a file descriptor. This PR fixes that.

@codecov-io
Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #246 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   75.22%   75.31%   +0.08%     
==========================================
  Files          11       11              
  Lines         553      555       +2     
  Branches      126      126              
==========================================
+ Hits          416      418       +2     
  Misses         48       48              
  Partials       89       89
Impacted Files Coverage Δ
lib/ecstatic.js 72.92% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6481ff4...b9a994f. Read the comment docs.

@jfhbrook
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants