elm-review stalls on Windows after upgrading to 2.13

[bdukes]

We're having issues with elm-review after upgrading, I think it's Windows-only. The review application runs but never outputs anything or exits. I can reproduce with a simple example, e.g. https://github.com/bdukes/elm-review-repro (which runs fine on WSL).

I think there are two issues occurring here. The first looks like it has something to do with the tinyglobby npm library. When I duplicate the logic from elm-review in a separate example app, it stalls out with tinyglobby 0.2.10, but finds the files with tinyglobby 0.2.12. However, even on 0.2.12, it does not find the files when it's called from the root directory (i.e. when the file is a child of cwd), but only when called from a separate directory. I can try to open an issue on their repo for that (though I'm not 100% sure there's no issue with how elm-review is translating the Windows path to the glob path).

The second issue is that, since elm-review is finding zero files, it is never receiving the acknowledgeFileReceipt message and so never knows that it's done. It's not showing the "NO FILES FOUND" message because options.directoriesToAnalyze.length is 0, I'm not sure if that's a valid reason to bypass that message in this scenario or not.

Happy to debug and try resolutions.

[jfmengels]

@bdukes The fix is released in v2.13.2. I hope this allows you to start the week with a working elm-review!

[bdukes]

I've upgraded and confirmed that everything is working as expected for us now. Thanks!