Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Ignore missing fields while deserialize HTTP response #502

Merged
merged 5 commits into from
May 27, 2021
Merged

Fix: Ignore missing fields while deserialize HTTP response #502

merged 5 commits into from
May 27, 2021

Conversation

gailazar300
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

@gailazar300 gailazar300 requested review from eyalbe4 and yahavi May 26, 2021 09:11
yahavi
yahavi requested changes May 26, 2021
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to remove the ignoreMissingFields at all and always ignore missing fields.

@gailazar300
remove ignoreMissingFields condition from getMapper()
31edd7c
@gailazar300
Merge branch 'master' of https://github.com/jfrog/build-info into fix…
00132af 
…-mapping

# Conflicts:
#	build-info-extractor/src/main/java/org/jfrog/build/extractor/clientConfiguration/client/artifactory/services/GetRepositoriesKeys.java
@gailazar300 gailazar300 merged commit 179755f into jfrog:master May 27, 2021
@gailazar300 gailazar300 mentioned this pull request May 27, 2021
Closed
@yahavi yahavi linked an issue May 28, 2021 that may be closed by this pull request
All publish tasks fail with: Unrecognized field "slf" #506
Closed
@mafgh mafgh mentioned this pull request Jul 6, 2021
Open
@yahavi yahavi mentioned this pull request Mar 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All publish tasks fail with: Unrecognized field "slf"
2 participants
@gailazar300 @yahavi