Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set repo/owner in different fields for webhookinfo #19

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

RemiBou
Copy link
Contributor

@RemiBou RemiBou commented Dec 6, 2021

This returns the repo owner and name as distinct field, and also fixes some inconsistencies with GetRepositories where we would return the slug and the webhook would return the name

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@RemiBou
Copy link
Contributor Author

RemiBou commented Dec 6, 2021

I have read the CLA Document and I hereby sign the CLA

@RemiBou RemiBou force-pushed the fix-repository-webhookinfo branch from c54bed6 to e0b7f40 Compare December 7, 2021 07:43
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have only 1 comment. Please let me know what do you think.

vcsutils/webhookparser/webhookparser.go Outdated Show resolved Hide resolved
Co-authored-by: Yahav Itzhak <[email protected]>
@RemiBou RemiBou force-pushed the fix-repository-webhookinfo branch from 3442b44 to 01dc963 Compare December 7, 2021 14:13
@RemiBou
Copy link
Contributor Author

RemiBou commented Dec 7, 2021

@yahavi did the renaming of the Branch field

@yahavi yahavi merged commit 5540aa7 into jfrog:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants