Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wrapper by default in audit maven & gradle #681

Merged
merged 57 commits into from
Mar 14, 2023
Merged

Use wrapper by default in audit maven & gradle #681

merged 57 commits into from
Mar 14, 2023

Conversation

sarao1310
Copy link
Contributor

@sarao1310 sarao1310 commented Jan 26, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@sarao1310 sarao1310 changed the base branch from master to dev January 26, 2023 12:13
@sarao1310 sarao1310 requested a review from eyalbe4 January 26, 2023 12:13
eyalbe4
eyalbe4 suggested changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project doesn't compile and as a result the tests are failing.
I'd be happy to review this PR once the tests are green.

image

@sarao1310 sarao1310 requested review from omerzi and yahavi February 27, 2023 10:44
@sarao1310 sarao1310 temporarily deployed to frogbot February 28, 2023 10:04 — with GitHub Actions Inactive
@sarao1310 sarao1310 changed the title Support wrapper maven audit use wrapper by default in audit maven&gradle Mar 1, 2023
@sarao1310 sarao1310 requested a review from eyalbe4 March 2, 2023 09:05
@sarao1310 sarao1310 changed the title use wrapper by default in audit maven&gradle Use wrapper by default in audit maven & gradle Mar 2, 2023
@eyalbe4 eyalbe4 added the improvement Automatically generated release notes label Mar 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

What is Frogbot?

eyalbe4
eyalbe4 suggested changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statis analysis check is failing. Is is recommended to ensure all tesst are green before assigning the PR for review.

eyalbe4
eyalbe4 suggested changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to review this PR again once you reply to my comments.

artifactory/utils/buildinfoproperties.go Outdated Show resolved Hide resolved
artifactory/utils/buildinfoproperties.go Outdated Show resolved Hide resolved
utils/mvn/utils.go Outdated Show resolved Hide resolved
utils/mvn/utils.go Outdated Show resolved Hide resolved
utils/mvn/utils.go Outdated Show resolved Hide resolved
xray/audit/java/mvn.go Outdated Show resolved Hide resolved
xray/audit/java/mvn.go Outdated Show resolved Hide resolved
xray/audit/java/mvn.go Outdated Show resolved Hide resolved
xray/audit/java/mvn_test.go Outdated Show resolved Hide resolved
xray/audit/java/mvn_test.go Show resolved Hide resolved
sarao1310 and others added 20 commits March 12, 2023 12:00
@sarao1310
GitLab Audit UI Improvements
b9865bd
@sarao1310
GitLab Audit UI Improvements
3a634be
@sarao1310
Support Wrapper By Default In Maven Audit
cecb237
@sarao1310
Support Wrapper By Default In Maven Audit
2d7faf3
@sarao1310
Support Wrapper By Default In Maven Audit
aeee963
@sarao1310
Support Wrapper By Default In Maven Audit
ac20017
@sarao1310
Support Wrapper By Default In Maven Audit
4086519
@sarao1310
Support Wrapper By Default In Maven Audit
5e90b22
@gailazar300 @sarao1310
Add Advanced Security to Xray's offline DB sync (#686)
7a836be
@sarao1310
GitLab Audit UI Improvements (#699)
25c9d41 
* GitLab Audit UI Improvements

* GitLab Audit UI Improvements
@omerzi @sarao1310
Upgrade jfrog-cli-core to 2.29.7 (#700)
ac56f88
@yahavi @sarao1310
Transfer config - Improve repositories transfer (#689)
4449c19
@EyalDelarea @omerzi @sarao1310
Add new attributes to technologiesData (#696)
0e38ea7 
* add new attributes to technologiesData
---------

Co-authored-by: Omer Zidkoni <[email protected]>
@sarao1310
Enhancements to the progress bars code (#687)
e70ba18
@sarao1310
Support Wrapper By Default In Maven Audit (#701)
0d5f824
@sarao1310
Merge branch 'support-Wrapper-maven-audit' of https://github.com/jfro…
a562b5f 
…g/jfrog-cli-core into HEAD

� Conflicts:
�	go.mod
�	xray/commands/offlineupdate/offlineupdate.go
@sverdlov93 @sarao1310
Improve npm install command log (#702)
20eeb4e 
Signed-off-by: Michael Sverdlov <[email protected]>
@omerzi @sarao1310
Upgrade jfrog-cli-core to 2.29.7
af5028f
@sarao1310
Merge remote-tracking branch 'upstream/dev' into support-Wrapper-mave…
6f43199 
…n-audit

# Conflicts:
#	artifactory/commands/mvn/mvn.go
#	artifactory/utils/buildinfoproperties.go
#	go.sum
#	utils/mvn/utils.go
#	xray/audit/java/mvn.go
#	xray/audit/java/mvn_test.go
#	xray/commands/audit/generic/auditmanager.go
@sarao1310
Support Wrapper By Default In Maven Audit
90e6e9a
@sarao1310 sarao1310 merged commit 7f1bb1e into dev Mar 14, 2023
@p-linnane p-linnane mentioned this pull request Mar 16, 2023
Closed
@sverdlov93 sverdlov93 deleted the support-Wrapper-maven-audit branch April 3, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sarao1310 @eyalbe4 @yahavi @Or-Geva @omerzi @sverdlov93 @RobiNino @gailazar300 @EyalDelarea