Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curation support for GitHub summary #111

Merged
merged 10 commits into from
Jul 25, 2024
Merged

Conversation

asafambar
Copy link
Contributor

@asafambar asafambar commented Jul 21, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Description:
Added curation to the overall security summary as part of Github integration, adding an example of the md file:
image

@asafambar asafambar added the safe to test Approve running integration tests on a pull request label Jul 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 21, 2024
@attiasas attiasas added the improvement Automatically generated release notes label Jul 22, 2024
@asafambar asafambar added the safe to test Approve running integration tests on a pull request label Jul 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 22, 2024
@asafambar asafambar added the safe to test Approve running integration tests on a pull request label Jul 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 23, 2024
@asafambar asafambar added the safe to test Approve running integration tests on a pull request label Jul 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 23, 2024
@asafambar asafambar added the safe to test Approve running integration tests on a pull request label Jul 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 23, 2024
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, check out my comments

formats/summary.go Outdated Show resolved Hide resolved
utils/securityJobSummary.go Outdated Show resolved Hide resolved
commands/curation/curationaudit.go Show resolved Hide resolved
commands/curation/curationaudit.go Show resolved Hide resolved
commands/curation/curationaudit.go Show resolved Hide resolved
commands/curation/curationaudit_test.go Outdated Show resolved Hide resolved
@asafambar asafambar added the safe to test Approve running integration tests on a pull request label Jul 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 24, 2024
@asafambar asafambar added the safe to test Approve running integration tests on a pull request label Jul 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 24, 2024
@asafambar asafambar added the safe to test Approve running integration tests on a pull request label Jul 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 24, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jul 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 25, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit b89f58d into jfrog:dev Jul 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants