Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wrapper by default in audit maven & gradle #1804

Merged
merged 9 commits into from
Mar 14, 2023
Merged

Use wrapper by default in audit maven & gradle #1804

merged 9 commits into from
Mar 14, 2023

Conversation

sarao1310
Copy link
Contributor

@sarao1310 sarao1310 commented Jan 12, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@sarao1310 sarao1310 requested review from eyalbe4 and yahavi January 16, 2023 10:24
@sarao1310 sarao1310 changed the title Support gradle wraapper audit Support gradle wrapper audit Jan 16, 2023
@sarao1310 sarao1310 changed the base branch from v2 to dev January 16, 2023 10:47
@sarao1310 sarao1310 force-pushed the support-Gradle-Wraapper-audit branch from 99fa7da to d92bb94 Compare January 16, 2023 10:50
@sarao1310 sarao1310 force-pushed the support-Gradle-Wraapper-audit branch from d92bb94 to ebbc314 Compare January 16, 2023 11:09
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Jan 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 17, 2023
@eyalbe4 eyalbe4 added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes labels Jan 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 17, 2023
@eyalbe4 eyalbe4 changed the title Support gradle wrapper audit Support gradle wrapper in audit Jan 30, 2023
eyalbe4
eyalbe4 requested changes Jan 30, 2023
View reviewed changes
utils/cliutils/commandsflags.go Outdated Show resolved Hide resolved
@sarao1310 sarao1310 requested a review from eyalbe4 February 12, 2023 10:40
eyalbe4
eyalbe4 requested changes Feb 14, 2023
View reviewed changes
utils/cliutils/commandsflags.go Outdated Show resolved Hide resolved
@sarao1310 sarao1310 requested a review from yahavi February 27, 2023 10:45
@sarao1310 sarao1310 changed the title Support gradle wrapper in audit use wrapper by default in audit maven&gradle Mar 1, 2023
@sarao1310 sarao1310 requested a review from eyalbe4 March 2, 2023 09:14
@eyalbe4 eyalbe4 changed the title use wrapper by default in audit maven&gradle Use wrapper by default in audit maven&gradle Mar 2, 2023
@eyalbe4 eyalbe4 changed the title Use wrapper by default in audit maven&gradle Use wrapper by default in audit maven & gradle Mar 2, 2023
@sarao1310 sarao1310 changed the title Use wrapper by default in audit maven & gradle use wrapper by default in audit maven & gradle Mar 2, 2023
@sarao1310 sarao1310 changed the title use wrapper by default in audit maven & gradle Use wrapper by default in audit maven & gradle Mar 2, 2023
eyalbe4
eyalbe4 requested changes Mar 3, 2023
View reviewed changes
utils/cliutils/commandsflags.go Outdated Show resolved Hide resolved
@sarao1310 sarao1310 requested review from eyalbe4 and removed request for eyalbe4 March 5, 2023 21:17
@sarao1310 sarao1310 requested review from eyalbe4 and removed request for eyalbe4 March 6, 2023 09:25
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Mar 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 7, 2023
@sarao1310 sarao1310 merged commit b75a82a into jfrog:dev Mar 14, 2023
@p-linnane p-linnane mentioned this pull request Mar 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarao1310 @eyalbe4 @yahavi