Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artifactory resolution tests: Python, Java, Go #2354

Merged
merged 16 commits into from
Dec 18, 2023
Merged

Artifactory resolution tests: Python, Java, Go #2354

merged 16 commits into from
Dec 18, 2023

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Dec 12, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

This PR completes Artifactory resolution tests that started in #2347, for all supported package managers. In this PR we added checks for the following package managers:
Pip, Pipenv, Poetry, Golang, Maven, Gradle
The tests verify dependencies resolution from an Artifactory server using the 'audit' flow.

Transfer tests are known to fail in this PR. A fix that should resolve this issue was added to this PR in xrayTests.yml

@eranturgeman eranturgeman marked this pull request as draft December 12, 2023 12:29
@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Dec 12, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 12, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 12, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 12, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 12, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 12, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 12, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 12, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 14, 2023
@eranturgeman eranturgeman marked this pull request as ready for review December 14, 2023 09:57
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 14, 2023
@eranturgeman eranturgeman requested a review from yahavi December 14, 2023 09:59
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 14, 2023
@eranturgeman eranturgeman requested a review from eyalbe4 December 14, 2023 14:41
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Dec 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 17, 2023
eyalbe4
eyalbe4 suggested changes Dec 17, 2023
View reviewed changes
xray_test.go Show resolved Hide resolved
@eranturgeman
added an error return value to cleanTestsHomeEnv and checked the retu…
72fac5e 
…rn value in every usage where we can apply the check
@eranturgeman
Merge remote-tracking branch 'erant-fork/artifactory-resolution-tests…
40f6c08 
…-python-java-go-new' into artifactory-resolution-tests-python-java-go-new
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 17, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@eranturgeman eranturgeman merged commit ccd80bc into jfrog:dev Dec 18, 2023
56 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @eyalbe4