Replaced __del__ with _cleanup to avoid assumptions about object state #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing use of
__del__makes erroneous assumptions about the state of thewsobject, which may or may not exist when it's called.This causes calls to
ws_2811_finianddelete_ws2811_tto fail, provoking a landslide of errors and memory leak warnings upon exit.This fix add a new
_cleanuproutine that is triggered before objects are deleted, correctly cleaning up the state of ws2811.Note: I also believe this library should be normalized to indentation of 4 spaces, as is conventional for Python, and not tabs. But that's something for another PR.