-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add per-channel user-settable gamma correction #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pi Zero W v1.1 support added to rpihw.c
Pi Zero W v1.1 support added to rpihw.c
added raspi Zero W
…#170) select either PWM, PCM or SPI. PCM and SPI only support 1 channel. Increased version to 1.1.0. Updated README.md
Thanks for the pull request. I'd like to merge this but it has quite a few other changes in the history, some of which I just merged. Would you mind rebasing it to the current tip of master and resubmit? Thanks. |
* updated documentation on GPIO usage strandtest now defaults to GRB colour order added version.h to gitignore * updated python readme * more README cleanup * added notes on spi max transfer size
dpenezic
added a commit
to dpenezic/rpi_ws281x
that referenced
this pull request
Jan 10, 2018
Add per-channel user-settable gamma correction (jgarff#171)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds per-channel user-settable gamma correction which uses a single set of values to correct intensity values for all LED elements- Red, Green, Blue and White.
The default gamma table is uncorrected, in Unicorn HAT we use:
But I did not want to foist a default which might suddenly change behaviour upon unsuspecting users.
It's not ideal, so I'm open to suggestions for improvements, but currently the gamma table must be set following init, where the table is allocated in memory and the default values are stored.
Actually, would it be sensible to simply check for NULL on the uninitialised pointer and only initialise it only if it doesn't already contain the address of a gamma table array?
https://github.com/pimoroni/rpi_ws281x/blob/master/ws2811.c#L937-L942