Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mono wrapper #58

Closed
wants to merge 3 commits into from
Closed

mono wrapper #58

wants to merge 3 commits into from

Conversation

zivillian
Copy link

a mono wrapper (Pivoke) to use ws281x from c#, tested on rpi b+

@Gadgetoid
Copy link
Collaborator

I very strongly believe that this wrapper should live in its own repository, and include rpi_ws281x as a submodule, otherwise the ongoing maintenance burden for fixes/improvements will fall upon the maintainers of rpi_ws281x who may not necessarily have any expertise with mono.

Since you took the time to submit this wrapper, I'd love your feedback on this proposal. Please see here: #267

Gadgetoid
Gadgetoid requested changes Mar 6, 2018
View reviewed changes
Copy link
Collaborator

@Gadgetoid Gadgetoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe it's a healthy direction for the rpi_ws281x project to be taking upon the burden of additional wrappers.

This should be housed within its own repository - perhaps under an rpi_ws281x GitHub org eventually - and linked in the README.

@Gadgetoid Gadgetoid mentioned this pull request Mar 13, 2018
Closed
@zivillian zivillian closed this Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gadgetoid Gadgetoid Gadgetoid requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zivillian @Gadgetoid