Docbook 5 writer: use xml:id tag

[mjang]

When converting from (canonical) Markdown to Docbook 5, tags include only id, such as

<section id="basic-formatting">

It should convert to

<section xml:id="basic-formatting">

The feature request was included in this comment from issue 2164.

[mjang]

I've verified when converting from

1. the canonical markdown (daring fireball)
2. CommonMark
3. GH flavored markdown

[mb21]

seems like we should indeed use the xml prefix (any reason why we don't do that here? @IvoBCD ?). But we don't have to declare it...

from Namespaces in XML 1.1:

The prefix xml is by definition bound to the namespace name http://www.w3.org/XML/1998/namespace. It MAY, but need not, be declared, and MUST NOT be bound to any other namespace name.

[mb21]

I've hopefully fixed this in this pull and added the correct namespace in this pandoc-templates pull. Did I make all the correct changes @mjang ?

[mjang]

It looks all right -- I'd check but am having trouble installing the stack build tool. Thank you for your fix, and following up. Thanks, Mike

…

On Thu, Dec 29, 2016 at 12:52 AM, Mauro Bieg ***@***.***> wrote: I've hopefully fixed this in this pull <#3330> and added the correct namespace in this pandoc-templates pull <https://github.com/jgm/pandoc-templates/pull/226>. Did I make all the correct changes @mjang <https://github.com/mjang> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3329 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADIrqFO9mGyDoMeq2_EIoNG5r0-sXlsEks5rM3S5gaJpZM4LWZ07> .