Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML writer: don't process pars with empty RawInline, fixes #1040 #3327

Merged
merged 1 commit into from
Dec 24, 2016

Conversation

mb21
Copy link
Collaborator

@mb21 mb21 commented Dec 24, 2016

No description provided.

@jgm
Copy link
Owner

jgm commented Dec 24, 2016

The build failures due to happy should be fixed by the latest update to .travis.yml.
But there is one warning that should be fixed before we merge:

/home/travis/build/jgm/pandoc/src/Text/Pandoc/Writers/HTML.hs:460:29: warning: [-Wunused-matches]
    Defined but not used: ‘str’

@mb21
Copy link
Collaborator Author

mb21 commented Dec 24, 2016

of course... btw, I'm getting quite a few warnings in the markdown reader with stack build --ghc-options="-Wall"

.../Readers/Markdown.hs:1891:3: warning: [-Wunused-do-bind]
A do-notation statement discarded a result of type ‘String’

@jgm
Copy link
Owner

jgm commented Dec 24, 2016

I always use "-Wall -fno-warn-unused-do-bind".

@jgm
Copy link
Owner

jgm commented Dec 24, 2016

Note also that the default ghc options (from the cabal file) include -Wall -fno-warn-unused-do-bind. So you shouldn't need to specify ghc-options separately on stack.

@mb21
Copy link
Collaborator Author

mb21 commented Dec 24, 2016

ah right, then I must have overlooked it...

@mb21
Copy link
Collaborator Author

mb21 commented Dec 24, 2016

(fixed and rebased btw)

@jgm
Copy link
Owner

jgm commented Dec 24, 2016

OK, I see the problem with the builds that failed. Fixed now I think.
I'll merge this, thanks!

@jgm jgm merged commit 9b29a55 into jgm:master Dec 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants