General cleanup and improved output from check/in/out #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now outputting more activity statements to the concourse web ui. For example, each active source filter is printed out from `check` as it is evaluated. Fixed a bug in the `log()` method that leaked param args from previous invocation to the global context. For example, ``` log "private message 1" log -p "public message 2" log "private message 3" ``` Would print to the concourse ui: ``` public message 2 private message 3 ``` Fixed this by using `local` declarations for those param args. Finally, did some general cleanup and better organization of the `common` script, and in the tests.
jgriff
added
the
polish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now outputting more activity statements to the concourse web ui. For
example, each active source filter is printed out from
checkas it isevaluated.
Fixed a bug in the
log()method that leaked param args from previousinvocation to the global context. For example,
Would print to the concourse ui:
Fixed this by using
localdeclarations for those param args.Finally, did some general cleanup and better organization of the
commonscript, and in the tests.