#75 use a connection factory with automatic recovery disabled by default #82
Conversation
|
@jhalterman I think this is good to be merged. Should a new (point?) release be produced as well? |
|
@jhalterman sorry, any thoughts? If you have absolutely no time for Lyra, can you add me as a project owner so that I can at least merge small PRs? |
|
Anything new on this? |
|
I'm trying to reach out to the maintainer via means other than GitHub to obtain the permissions so that user PRs like this one can be merged quickly. |
|
@michaelklishin I suggest to put an Assertion when the connection is been created, see my PR. |
| @@ -49,7 +49,7 @@ private ConnectionOptions(ConnectionOptions options) { | |||
| nioParams = options.nioParams; | |||
| useNio = options.useNio; | |||
|
|
|||
| factory = new ConnectionFactory(); | |||
| factory = makeConnectionFactory(); | |||
| factory.setAutomaticRecoveryEnabled(options.factory.isAutomaticRecoveryEnabled()); | |||
There was a problem hiding this comment.
Small, but I guess this setter is no longer needed here
|
Does the main README and it's examples need to be updated to reflect that automatic recovery is disabled by default in 0.5.5? Also, if I had been using a recovery policy, should I remove that from my config because recovery is now disabled? |
Java client's automatic recovery is disabled by default, not Lyra's. There's already a warning in the readme to make sure automatic recovery is not enabled for both libraries.
Disabling automatic recovery in the underlying Java client should not affect Lyra's recovery policy. Please note this project is no longer maintained. |
#75