-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nextcloud 13 #67
Comments
Hi nougad, you can adjust the dependencies / max-version, and activate the App again.
|
Nextcloud 13 beta 3 is already out: https://nextcloud.com/blog/nextcloud-13-beta-3-ready-for-your-testing-go-and-win-a-t-shirt/ see jhass#67
Tbh. I'm reluctant to update this to support NC 13 until nextcloud/server#34 is resolved. I consider the current state essentially broken and doing an update would give a false sense of progress on that. Last time I checked, nextcloud/server#34 couldn't be resolved without new upstream features (I consider having to statically register each and every mimetype upstream improper), but I couldn't check, track or push for the necessary upstream changes due to lack of time and motivation. I would be happy if anybody could do that. Meanwhile I'm open to workarounds that don't heavily degrade performance. |
@jhass Which upstream features would be needed for this app to be useable again? |
A reliable and performant way to update the mime type registry from a plugin (which also should trigger a performant/background rescan of the files to update any associations). |
@jhass Maybe this issue covers your problem as well: |
nextcloud/viewer#2393 is a feature request (mapping apps to mime types) unrelated to nextcloud/server#34 (mapping extensions to mime types). |
While 8105 would surely greatly simplify this plugin, what @Yetangitu said is true. The prequisite to easily asosciate an app with a mimetype is, for keeweb, to register new ones. |
The manual workaround suggested in nextcloud/server#34 worked for me. Perhaps a guide on editing the file (or even doing it automagically) would help? |
I don't want that anywhere near an endorsed method to do it, sorry. It's prone to (user) errors and will be overwritten by updates. |
Ah, good point. Never mind then. We're waiting on support from Nextcloud then, I suppose. There is an issue opened against Nextcloud for this, right? |
I don't know, I currently don't have the time to follow Nextcloud development, sorry. |
Any news? |
If you use https://YOUR_DOMAIN/apps/keeweb?open=/file.kdbx it will open the app and place it in recent (recent gets cleared periodically). This will require version bump in app info. You can use External Sites app to embed a direct link to your KDBX with an icon in the Navbar of the Nextcloud interface. This is far from ideal but it works well enough for myself! Would love if I could find some time to take a look at this integration project and contribute to Nextcloud 13 support. |
Owwh I'm so existed to switch from LastPass to Keeweb... 😁 Once this is all fixed, I will go to keeweb anytime soon... |
I can activate the app after making the required version change, but I just get an "Internal Server Error" but there are no details and I'm not seeing anything wrong in my logs. Likewise if I try using the URL @justintime4tea suggested with the path to my file. I thought maybe permissions error but chmod 777 didn't correct it. I also was not sure whether to place this app in custom_apps or apps subfolder, but I get the same behavior in both (seems like it should go in custom_apps). Anyone using this successfully on a current NC13 installation? I am using the stable docker image. |
@oakbrad, I'm also using NC13 docker container. I know that doesn't help much, but for reference in case anyone is wondering. I'll take a look sometime this weekend and see if I did anything special and can share my docker volume mount configuration and any other info that can help. |
Actually I got it working by deleting and starting over. I think I possibly had a permissions issue with Docker. The other thing I did differently was set "max-version" at 14. I wonder if this is necessary since I'm on 13.0.1. |
@jhass There are other apps out there which have the same problem, for example Ownpad. But they deal with it by explaining how to add the custom mimetype: https://apps.nextcloud.com/apps/ownpad This links to the documentation as following: https://github.com/otetard/ownpad/blob/master/README.md#mimetype-detection Even though this is not ideal, it's better than naving no app at all. I did this for Keeweb and it works totally fine in my NC 13 instance. |
@arnowelzel: Great 👍, could you please update the Readme.md for this app with you adjustments. And send a pull request, if i find some time i would test your solution. |
yes, also Audio Player suggests this "workaround". |
@mr-bolle I just created the pull request for the Readme.md updated. |
Now Nextcloud 14 is around the corner, Is this app still compatible with it? NC 14 brings a lot of breaking changes, so it would be interesting to see if it still works. |
And now, NC14 is here. The trick to modify info.xml does not work anymore (well, it does, but the result is not usable) and we ,the users, need a usable version. I know the talk is still in progress (since NC13 release...), but maybe you can release a temporary fix to make keeweb usable again until you found a definitive solution ? And why not upgrade keeweb to 1.6 at the same time ? ;) Don't get myself wrong, I really appreciate your work and thank you a lot for that ! Regards, |
@zerpex:
|
Hey, @onny! Have you considered opening a Pull Request for that? |
@onny Confirmed. Thanks for the tip, but it would be nice if the project goes on again :) |
Sorry to interfer but trying to install the extension as explained and it’s not possible to activate it. I suppose I have to wait for a new version ? |
@Li-An you have to set "max-version" in
And of course you also need to modify
Is there already a pull request for that? |
max version to 13 yes there are PRs, but not yet 14 ><... |
@arnowelzel thanks a lot. I will have have look. |
I think not releasing the app to the App Store is not the best idea. If it is listed as an app there, available for the latest release, then more users can be reached (and Keepass pretty much is a de facto standard now even getting a software audit by the EU) which could generate enough support to get the missing feature implemented upstream (maybe either by someone implementing it or providing enough money through Bountysource so somebody tackles it for example). |
Agree, keeweb is dropping off the radar. Rather an intermediate solution now to keep the user base and grow it than to wait until an alternative takes over. |
It's been quite a while now we are approaching the end of the year. Isn't it time to probably accept mimetype registration isn't coming any time soon and just accept admins will have to be responsible? At the very least merging a pull requests making it all compatible with nc14 to allow manual installation without updating the store page. |
It might be worth creating a temporary fork in order to merge a bunch of PRs, and then potentially co-ordinate a re-merge at a later time if this project is no longer maintained. |
@jhass Regarding the Mimetype problem: Maybe you could take a look at the Epub reader app that can do mimetype registrations for certain filetypes: https://github.com/Yetangitu/owncloud-apps/blob/457c1603fad5132ed17e27e99642c56381f169a0/files_reader/lib/Controller/PageController.php |
@e-alfred Sorry, could you be more specific? I fail to understand how that makes it work unfortunately. Pull requests that adapt the method to this plugin are more than welcome! |
@jhass Would that plugin not help to solve the problem? |
No, not at all. |
Try 0.5.0 Never tested it for NC13 but it should work :) Take care to do the required manual steps as outlined in the readme! |
@jhass Great news! Thanks for all your work! |
Nextcloud 13 beta 3 is already out since a week: https://nextcloud.com/blog/nextcloud-13-beta-3-ready-for-your-testing-go-and-win-a-t-shirt/
Unfortunately keeweb is not supported yet. It results in the error:
Any plans to support NC13?
The text was updated successfully, but these errors were encountered: