fix resolution of AsyncStorage (#435) #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the resolution now matches the resolution of the @react-native-community/async-storage package.
jhen0409
requested changes
Nov 21, 2019
app/worker/asyncStorage.js
Outdated
| NativeModules.AsyncLocalStorage); | ||
| (NativeModules.RNC_AsyncSQLiteDBStorage || | ||
| NativeModules.RNCAsyncStorage || | ||
| NativeModules.PlatformLocalStorage); |
There was a problem hiding this comment.
We need to keep using the native modules from react-native as fallback for who haven't yet to link @react-native-community/async-storage. Just make sure RNCAsyncStorage in front.
There was a problem hiding this comment.
Sure, just pushed the fix.
jhen0409
approved these changes
Nov 22, 2019
|
Thanks! |
cryptodev523
pushed a commit
to cryptodev523/react-native-debugger
that referenced
this pull request
Jan 27, 2022
* fix resolution of AsyncStorage (jhen0409#435) the resolution now matches the resolution of the @react-native-community/async-storage package. * add fallback dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the resolution now matches the resolution of the @react-native-community/async-storage package.
@jhen0409, this includes the fix I suggested in #435. But while it works, we simply replicate the logic of the async-storage-lib. Is there a way to e.g. do something like this:
This obviously does not work, but illustrates my point. It would make maintaining this part of the debugger probably a bit easier.
Anyway, thanks for welcoming my pull request. I hope this helps.