Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Yarn, NodeJS, NPM, frontend-maven-plugin #6424

Merged
merged 2 commits into from
Sep 28, 2017

Conversation

pascalgrimaud
Copy link
Member

  • Yarn 1.0.2
  • NodeJS 6.11.3
  • NPM 5.4.2
  • frontend-maven-plugin 1.6
  • remove cache, and use global node 6.11.3
  • use yarn global add file, instead of yarn link

Fix #6362


- Yarn 1.0.2
- NodeJS 6.11.3
- NPM 5.4.2
- frontend-maven-plugin 1.6
- remove cache, and use global node 6.11.3
- use yarn global add file, instead of yarn link
Copy link
Member

@deepu105 deepu105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@@ -16,14 +16,12 @@ if [ "$JHIPSTER" == "app-ng2-gateway-uaa" ]; then
mkdir -p "$UAA_APP_FOLDER"
cp -f "$JHIPSTER_SAMPLES"/uaa/.yo-rc.json "$UAA_APP_FOLDER"/
cd "$UAA_APP_FOLDER"
yarn link generator-jhipster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this link happen now? if yarn link doesnt work we should just use npm link here, they both can co exist without issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have no idea how the "link" happens now! But I just checked this build, and it's using Gradle 4.2, which is one of our recent merged PR, so this definitely uses the dev version (this hasn't been released yet)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, in Travis, I don't use yarn link, but use this instead: yarn global add file:"$TRAVIS_BUILD_DIR", so it will install globally the version from this folder (the master version)

yarn link seems to be totally broken with Travis, and sometimes in my local too. When it happens, I need to clear some folders in ~/.config/yarn and reinstall everything.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use npm link it works fine right

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only command where Yarn shines is when you install stuff for everything else npm commands are perfectly fine as well

@jdubois
Copy link
Member

jdubois commented Sep 28, 2017

Thanks @pascalgrimaud

@jdubois jdubois merged commit 31306a5 into jhipster:master Sep 28, 2017
@jdubois jdubois added this to the 4.9.0 milestone Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants