container-setup.sh: Fix binary checks in validate_prereqs. #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first check whether docker or podman bins are there; then choose one one of them
|
It worked for me because I have podman installed. 🤦♂️ Thanks for this! Also on line 60 it should be |
pushrbx
approved these changes
Oct 26, 2023
Vernoxvernax
added a commit
to Vernoxvernax/jikan-rest
that referenced
this pull request
Oct 27, 2023
Merge pull request jikan-me#450 from Vernoxvernax/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still a little confused by how the checks are done.
Like,
-nin line 60, instead of-x, like for the rest of the checks.These changes make it at least possible for me to create the containers.