Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update ESLint configuration and remove unused files #142

Merged
merged 9 commits into from
Nov 10, 2023
Merged

Conversation

jill64
Copy link
Owner

@jill64 jill64 commented Nov 10, 2023

This pull request updates the ESLint configuration to use the correct tsconfig.json file and removes the unused eslint.tsconfig.json file. It also reorders the lint script in package.json and formats the code. Additionally, it adds the tests and scripts directories to the list of ignored files in .gitignore and adds .config. to the list of files to ignore.

No issue reference.

Summary by CodeRabbit

  • Chores
    • Updated linting and formatting configurations for improved code quality.
    • Adjusted file path references in version control for better project structure management.

@wraith-ci wraith-ci bot enabled auto-merge November 10, 2023 06:39
Copy link

coderabbitai bot commented Nov 10, 2023

Walkthrough

The changes primarily focus on configuration files for ESLint, Prettier, and Git, adjusting ignored directories and files, and modifying TypeScript project references. These alterations streamline the linting and build processes, and refine version control exclusions.

Changes

File Change
.eslintignore, demo/.eslintignore Added /tests directory, *.config.* files, and /scripts directory to ignore list.
.eslintrc.yml, demo/.eslintrc.yml Changed TypeScript project reference from "./eslint.tsconfig.json" to "./tsconfig.json".
.gitignore, demo/.gitignore Adjusted file structure from "/dist" to "dist" and "build" to "/build".
.prettierignore Added /demo line at the beginning and removed it from the end.

Poem

🍂 As autumn leaves fall, we refine our code's hall, 🍁

🐇 Hopping through changes, in config files small. 📁

On this day in history, the Berlin Wall did fall, 🏰

So we celebrate freedom, in our codebase and all! 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2fb8b43
Status: ✅  Deploy successful!
Preview URL: https://c348e422.sentry-sveltekit-cloudflare.pages.dev
Branch Preview URL: https://issue-130.sentry-sveltekit-cloudflare.pages.dev

View logs

@wraith-ci wraith-ci bot merged commit 0a9ee1b into main Nov 10, 2023
4 checks passed
@wraith-ci wraith-ci bot deleted the issue-130 branch November 10, 2023 06:40
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 019a9ea and 2fb8b43.
Files ignored due to filter (4)
  • demo/eslint.tsconfig.json
  • demo/package.json
  • eslint.tsconfig.json
  • rsac.yml
Files selected for processing (7)
  • .eslintignore (1 hunks)
  • .eslintrc.yml (1 hunks)
  • .gitignore (1 hunks)
  • .prettierignore (1 hunks)
  • demo/.eslintignore (1 hunks)
  • demo/.eslintrc.yml (1 hunks)
  • demo/.gitignore (1 hunks)
Files skipped from review due to trivial changes (4)
  • .eslintignore
  • .eslintrc.yml
  • .prettierignore
  • demo/.eslintignore
Additional comments: 3
demo/.eslintrc.yml (1)
  • 10-10: The project reference has been updated to use the correct tsconfig.json file. Ensure that this file exists and contains the correct configuration for your TypeScript project.
-  project: ./eslint.tsconfig.json
+  project: ./tsconfig.json
demo/.gitignore (1)
  • 1-1: The change from "build" to "/build" makes the ignore rule root-specific. Ensure that this change doesn't affect any build processes or file references.
- build
+ /build
.gitignore (1)
  • 1-5: The change from "/dist" to "dist" may impact file path references or build processes. Please verify that this change is intentional and does not break any existing functionality.
- /dist
+ dist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant