-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update ESLint configuration and remove unused files #142
Conversation
WalkthroughThe changes primarily focus on configuration files for ESLint, Prettier, and Git, adjusting ignored directories and files, and modifying TypeScript project references. These alterations streamline the linting and build processes, and refine version control exclusions. Changes
Poem
TipsChat with CodeRabbit Bot (
|
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (4)
- demo/eslint.tsconfig.json
- demo/package.json
- eslint.tsconfig.json
- rsac.yml
Files selected for processing (7)
- .eslintignore (1 hunks)
- .eslintrc.yml (1 hunks)
- .gitignore (1 hunks)
- .prettierignore (1 hunks)
- demo/.eslintignore (1 hunks)
- demo/.eslintrc.yml (1 hunks)
- demo/.gitignore (1 hunks)
Files skipped from review due to trivial changes (4)
- .eslintignore
- .eslintrc.yml
- .prettierignore
- demo/.eslintignore
Additional comments: 3
demo/.eslintrc.yml (1)
- 10-10: The project reference has been updated to use the correct tsconfig.json file. Ensure that this file exists and contains the correct configuration for your TypeScript project.
- project: ./eslint.tsconfig.json + project: ./tsconfig.jsondemo/.gitignore (1)
- 1-1: The change from "build" to "/build" makes the ignore rule root-specific. Ensure that this change doesn't affect any build processes or file references.
- build + /build.gitignore (1)
- 1-5: The change from "/dist" to "dist" may impact file path references or build processes. Please verify that this change is intentional and does not break any existing functionality.
- /dist + dist
This pull request updates the ESLint configuration to use the correct tsconfig.json file and removes the unused eslint.tsconfig.json file. It also reorders the lint script in package.json and formats the code. Additionally, it adds the tests and scripts directories to the list of ignored files in .gitignore and adds .config. to the list of files to ignore.
No issue reference.
Summary by CodeRabbit