minor: exclude sentry-client from bundle

[jill64]

Summary by CodeRabbit

• Refactor

  • Streamlined the initialization process for better integration with error handling services.
  • Enhanced error handling capabilities with a new parameter for custom error functions.

• Documentation

  • Updated export documentation to reflect the availability of new module-level imports.

• Chores

  • Simplified import statements for improved maintainability and readability of the codebase.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	fcf2ab0
Status:	✅  Deploy successful!
Preview URL:	https://2afaa882.sentry-sveltekit-cloudflare.pages.dev
Branch Preview URL:	https://dev.sentry-sveltekit-cloudflare.pages.dev

View logs

[coderabbitai]

Walkthrough

The changes involve streamlining the import process by consolidating imports from a custom module, updating the init function to enhance its error handling capabilities with Sentry integration, and exporting all functions from the @sentry/sveltekit module to be available locally. This refactoring improves modularity and error management within the client-side codebase.

Changes

File Path	Change Summary
src/client/init.ts	Consolidated imports, updated init function signature to include handleError, replaced sentryInit with Sentry.init, and modified return value to use handleErrorWithSentry.
src/client/sentry/index.d.ts src/client/sentry/index.js	Added export statements to make all exports from @sentry/sveltekit module available locally.

🐇 In the code's burrow, beneath the autumn's glow,
Refactoring hops, and Sentry's watch does grow.
With imports aligned, and errors in check,
The rabbit's code leaps forward, without a speck. 🍂🔍

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between bd3804f and 4a0dc7b.

Files ignored due to filter (2)

• package.json
• pnpm-lock.yaml

Files selected for processing (3)

• src/client/init.ts (3 hunks)
• src/client/sentry/index.d.ts (1 hunks)
• src/client/sentry/index.js (1 hunks)

Files skipped from review due to trivial changes (1)

• src/client/sentry/index.d.ts

Additional comments: 5

src/client/sentry/index.js (1)

• 1-1: The change to re-export everything from @sentry/sveltekit/esm/index.client.js is a common pattern when creating a facade or proxy module that abstracts the underlying library. This allows for more control over the Sentry integration and can simplify import paths in the rest of the application. However, ensure that there are no name clashes or unwanted exports that could pollute the namespace or cause confusion.

src/client/init.ts (4)

• 1-5: The consolidation of Sentry imports into a single import from a custom module is a good practice for maintainability and can help with bundle size optimization if tree-shaking is properly configured. Ensure that the custom module ./sentry/index.js correctly re-exports all necessary Sentry functionalities.

• 25-38: > Note: This review was outside of the patch, so it was mapped to the patch with the greatest overlap. Original lines [7-44]

The init function has been refactored to accept an additional parameter and return a new function signature. This change should be verified across the codebase to ensure that all calls to init are updated to match the new signature and that the returned function is used correctly. Additionally, the use of default parameters for handleError in lines 32 and 44 ensures that the function is always callable, which is a good defensive programming practice.

• 25-38: > Note: This review was outside of the patch, so it was mapped to the patch with the greatest overlap. Original lines [35-42]

The Sentry initialization options have been expanded with additional configuration. It's important to verify that these new options (tracesSampleRate, replaysSessionSampleRate, replaysOnErrorSampleRate, and integrations) are correctly configured and that they align with the project's requirements for Sentry reporting.

• 44-44: The handleErrorWithSentry function is returned as a higher-order function wrapping the provided handleError function. This pattern is useful for extending the error handling logic without modifying the existing handleError function. Ensure that handleErrorWithSentry is implemented to correctly handle errors and report them to Sentry.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between bd3804f and fcf2ab0.

Files ignored due to filter (2)

• package.json
• pnpm-lock.yaml

Files selected for processing (3)

• src/client/init.ts (3 hunks)
• src/client/sentry/index.d.ts (1 hunks)
• src/client/sentry/index.js (1 hunks)

Files skipped from review due to trivial changes (2)

• src/client/sentry/index.d.ts
• src/client/sentry/index.js

Additional comments: 5

src/client/init.ts (5)

• 1-5: The refactoring to use local imports from ./sentry/index.js is a good practice for modularity and can help with mocking in tests or future changes in Sentry integration. Ensure that the local module correctly re-exports all necessary Sentry functionality.

• 25-38: > Note: This review was outside of the patch, so it was mapped to the patch with the greatest overlap. Original lines [7-44]

The init function has been refactored to accept an additional handleError parameter and return a function that optionally takes a handleError argument. This change increases the flexibility of error handling within the application. Ensure that all usages of init are updated to handle the new function signature.

• 31-32: The no-operation function () => {} is used as a default value for handleError in development mode when Sentry is not enabled. This is a sensible default to prevent errors when Sentry is not initialized, but ensure that this behavior is documented and understood by other developers who might expect a different behavior in development mode.

• 25-38: > Note: This review was outside of the patch, so it was mapped to the patch with the greatest overlap. Original lines [35-41]

The Sentry initialization options are being spread with ...sentryOptions, which allows for custom Sentry configurations to be passed in. This is a flexible approach but ensure that the options provided are compatible with Sentry's expected configuration structure and that there are no conflicts with the hardcoded options like tracesSampleRate and integrations.

• 44-44: The returned function now wraps handleErrorWithSentry, which suggests that all errors handled by the returned function will be processed by Sentry. This is a significant change in behavior and should be clearly communicated to the team to ensure that it aligns with the project's error handling strategy.