Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use matrix rotation when rotating by a multiple of 90 degrees #9

Closed
sjoerd108 opened this issue Apr 15, 2023 · 1 comment
Closed

Use matrix rotation when rotating by a multiple of 90 degrees #9

sjoerd108 opened this issue Apr 15, 2023 · 1 comment

Comments

@sjoerd108
Copy link
Member

Jimp has recently merged a change to the rotate algorithm where rotating by 90 degrees uses a more optimal matrix rotation algorithm. (jimp-dev/jimp#1209) This is causing one of our tests to fail. We should implement this shortcut as well as rotating a matrix is a lot easier than actually doing the math on where a pixel should be relocated to.
@sjoerd108
Copy link
Member Author

Fixed in 0.1.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjoerd108