-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use matrix rotate, if rotate angle is multiple of 90 degrees #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @hipstersmoothie |
hipstersmoothie
approved these changes
Feb 25, 2023
How would this be a breaking change? It seems to fix a bug. |
OK, sounds good. No version change needed then. |
🚀 PR was released in |
4 tasks
This was referenced May 24, 2024
This was referenced May 25, 2024
This was referenced May 29, 2024
This was referenced Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1101
What's Changing
Changing rotate algorithm if angle is multiple of 90 degree. For other rotate angle previous algorithm will be used.
Why Changing
rotate(90)
orrotate(-90)
, expected new width and height iswidth=oldHeight
andheight=oldWidth
. However, existing algorithms is adding an extra pixel to the rotated image.Tasks
jimp.d.ts
Release Notes
Fixes a bug where rotating by 90 degrees introduced extra pixels