-
-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jpeg-js dependency is vulnerable #1088
Comments
If you're using yarn, this is what you can do to force the version
|
Hi We're not using yarn, is there anything else that can be done? |
You can use https://www.npmjs.com/package/npm-force-resolutions if you're using npm |
To avoid this vulnerability for now, I use jimp-compact. https://github.com/unjs/jimp-compact
|
@kenryu42 how do you advice Jimb-compact over Jimp ? Jimp seems not supported any-more ... |
The main concern at the moment is the vulnerability found in the dependencies of jpeg-js. Jimp-Compact is a minimum size package with all the features of the original Jimp. It does not depend on vulnerable version of jpeg-js, which solves the problem at hand. The future maintenance of this project is another issue that needs to be discussed. |
It doesn't appear to avoid anything. It imports jimp, exactly as it is, with all its dependencies, and then bundles them together with vercel/ncc. You haven't avoided jpeg-js as far as I can tell, but rather, just hidden it. |
@hipstersmoothie, you made the most recent release and have merged the most recent PRs since the release. Any chance you could bump the jpeg-js dependency and release again? |
Maybe by merging #1090? |
Still infinite loop risk in dependency, jpeg-js. Probably not an issue for me?... Follow through at jimp-dev/jimp#1088
I am using |
Yes, you can use jimp-compact if you want to work around the audit without actually fixing the bug. See #1088 (comment) Personally, I would prefer to see the underlying issue fixed, rather than game the audit system. |
If you're using npm 7+, you can use "overrides": {
"jimp": {
"jpeg-js": "^0.4.4"
}
} https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides |
Hey together, any plans to update jpeg-js to |
🚀 Issue was released in |
Is your feature request related to a problem? Please describe.
Current version of @jimp/jpeg has a dependency on a vulnerable version of jpeg-js, this is causing it to be flagged with our sec-ops
Describe the solution you'd like
bump the version of jpeg-js to 0.4.4
The text was updated successfully, but these errors were encountered: