fix commonjs require #1020
Merged
fix commonjs require #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- before: const Jimp = require('jimp').default;
- after: const Jimp = require('jimp');
no changes for esm module
|
Will If not, will this be a major semver change? |
|
Good point. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
This little change is for js users who use commonjs-modules.
before the fix:
const Jimp = require('jimp').default;after the fix:
const Jimp = require('jimp');The esm module isn't affected. Other popular libraries use this fix as well.
What else might be affected
nothing
Tasks
jimp.d.ts