Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test matching strategy to include all test files #1161

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Change test matching strategy to include all test files #1161

merged 1 commit into from
Feb 5, 2023

Conversation

danielholmes
Copy link
Collaborator

What's Changing and Why

I noticed when running tests for core that one was missed:

> yarn test
yarn run v1.22.19
$ cross-env BABEL_ENV=test mocha --require @babel/register test/**/*.js


  Mime
    getType
      ✓ should return undefined if not found
      ✓ should return the correct mime
    getExtension
      ✓ should return undefined if not found
      ✓ should return the correct extension


  4 passing (26ms)

✨  Done in 0.83s.

But there are actually 5 tests. After the change included here:

> yarn test
yarn run v1.22.19
$ cross-env BABEL_ENV=test mocha --require @babel/register --recursive test --extension js


  redirect
    ✓ follows 301 redirect

  Mime
    getType
      ✓ should return undefined if not found
      ✓ should return the correct mime
    getExtension
      ✓ should return undefined if not found
      ✓ should return the correct extension


  5 passing (49ms)

✨  Done in 0.95s.

I also added a test script for the gif plugin and switched the all test scripts to match tests in a less error prone way.

What else might be affected

This is only development side. All tests seem to run fine still.

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

@hipstersmoothie hipstersmoothie added the internal Changes only affect the internal API label Feb 5, 2023
@hipstersmoothie hipstersmoothie merged commit c5784fe into jimp-dev:master Feb 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

🚀 PR was released in v0.22.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants