Reset-exif

[Sarabadu]

What's Changing and Why

fixes #1104
After doing the exif rotation, we reset the exif orientation to 1

see this commit to compare before and after this changes 48179a1

What else might be affected

Note: test are still failing because the calculated distance seems quite bigger now (can be the case that the hash is also considering exif metadata in consideration 🤔, should be like that or should only consider the actual image data??)

Tasks

• Add tests
• Update Documentation
• Update jimp.d.ts
• Add SemVer Label

[hipstersmoothie]

@Sarabadu build isn't working. could you update?

[Sarabadu]

@hipstersmoothie added an empty polyfill for the util.inspect used on modify_exif

btw looking for this util use, I realised that modify_exif seems not maintained anymore (and also the lib main dependency). Didn't find any better alternative out there, so if you feel not confident enough, we can close this PR

[bobzel]

Is this branch going to be updated further? The problem it's addressing is very important for making this library be a replacement for Sharp. I

[Sarabadu]

@bobzel this solution was working for my use case and also seems to work on the test, but didn't get more feedback on this.

the solution here uses an apparently unmantained dependency. so not sure if this PR will be merged anyways. i used modify-exif after jimp for make it work. hope it helps

[hipstersmoothie]

@Sarabadu I'd merge if the tests pass :D

[Sarabadu]

@Sarabadu I'd merge if the tests pass :D

@hipstersmoothie, as i mentioned in the description, the issue with the test is the calculated distance is also calculating exif information.

not sure how to solve that tbh, changing the expected distance values doesn't give much value, I think, any suggestion? remove those tests? any idea how to solve this on the distance function(seems like a breaking changes) ?

WDYT?

[Sarabadu]

@hipstersmoothie in case you miss it i made the changes to the tests, feel free to run the CI

[hipstersmoothie]

@Sarabadu Hey! I'm currently working on a major rewrite of everything and your changes are already included. No tba, still have a few things to figure out

[Sarabadu]

Glad to hear @hipstersmoothie In that case feel free to close this PR.

If you are doing
A mayor rewrite, maybe you can also try to not use the modify-exif too

[hipstersmoothie]

I'm not sure what that means but feel free to make a pr to the v1 branch !

[Sarabadu]

closing it as seems it will be solved in the rewrite