Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: thumbnails fix #6033

Merged
merged 2 commits into from
Aug 24, 2023
Merged

docs: thumbnails fix #6033

merged 2 commits into from
Aug 24, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Aug 23, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@JoanFM JoanFM requested a review from hanxiao as a code owner August 23, 2023 14:05
@JoanFM JoanFM added the area/docs This issue/PR affects the docs label Aug 23, 2023
@github-actions github-actions bot added size/S and removed area/docs This issue/PR affects the docs labels Aug 23, 2023
@JoanFM JoanFM closed this Aug 23, 2023
@JoanFM JoanFM reopened this Aug 23, 2023
@JoanFM JoanFM added the area/docs This issue/PR affects the docs label Aug 23, 2023
@JoanFM JoanFM closed this Aug 23, 2023
@JoanFM JoanFM reopened this Aug 23, 2023
@github-actions github-actions bot added size/XS area/docs This issue/PR affects the docs and removed area/docs This issue/PR affects the docs labels Aug 23, 2023
@JoanFM JoanFM closed this Aug 23, 2023
@JoanFM JoanFM reopened this Aug 23, 2023
@JoanFM JoanFM force-pushed the docs-thumbnails-fix branch 2 times, most recently from 4f9167e to 61425cb Compare August 23, 2023 18:16
@JoanFM JoanFM requested a review from nan-wang as a code owner August 23, 2023 18:16
@JoanFM JoanFM force-pushed the docs-thumbnails-fix branch 2 times, most recently from 4073b51 to 94b08ad Compare August 23, 2023 18:55
@github-actions github-actions bot added area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #6033 (a970924) into master (0a33cde) will decrease coverage by 4.88%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head a970924 differs from pull request most recent head f18740c. Consider uploading reports for the commit f18740c to get more accurate results

@@            Coverage Diff             @@
##           master    #6033      +/-   ##
==========================================
- Coverage   77.61%   72.73%   -4.88%     
==========================================
  Files         144      144              
  Lines       13788    13788              
==========================================
- Hits        10701    10029     -672     
- Misses       3087     3759     +672     
Flag Coverage Δ
jina 72.73% <100.00%> (-4.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
jina/__init__.py 56.00% <100.00%> (ø)

... and 45 files with indirect coverage changes

@JoanFM JoanFM force-pushed the docs-thumbnails-fix branch 3 times, most recently from 850cc63 to a970924 Compare August 24, 2023 13:29
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM force-pushed the docs-thumbnails-fix branch from a970924 to f18740c Compare August 24, 2023 13:41
@JoanFM JoanFM merged commit 23c7b8c into master Aug 24, 2023
@JoanFM JoanFM deleted the docs-thumbnails-fix branch August 24, 2023 13:49
@github-actions
Copy link

📝 Docs are deployed on https://docs-thumbnails-fix--jina-docs.netlify.app 🎉

@JoanFM JoanFM mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/docs This issue/PR affects the docs area/housekeeping This issue/PR is housekeeping size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant